You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "bncriju (via GitHub)" <gi...@apache.org> on 2025/01/23 14:50:49 UTC
[PR] Cleanup rules springboot examples [incubator-kie-kogito-examples]
bncriju opened a new pull request, #2059:
URL: https://github.com/apache/incubator-kie-kogito-examples/pull/2059
Fixes https://github.com/apache/incubator-kie-issues/issues/1780
Corrected the Readme.md
swagger UI url
name of jar to be executed in standalone (jar)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#1780] Cleanup rules springboot examples [incubator-kie-kogito-examples]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer merged PR #2059:
URL: https://github.com/apache/incubator-kie-kogito-examples/pull/2059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Cleanup rules springboot examples [incubator-kie-kogito-examples]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2059:
URL: https://github.com/apache/incubator-kie-kogito-examples/pull/2059#discussion_r1927123627
##########
kogito-springboot-examples/rules-legacy-scesim-springboot-example/README.md:
##########
@@ -43,13 +43,13 @@ mvn clean compile spring-boot:run
```sh
mvn clean package
-java -jar target/ruleunit-springboot-example.jar
+java -jar target/rules-legacy-scesim-springboot-example.jar
```
## OpenAPI (Swagger) documentation
[Specification at swagger.io](https://swagger.io/docs/specification/about/)
-You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger UI](https://editor.swagger.io).
+You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger](http://localhost:8080/swagger-ui/index.html).
Review Comment:
Pls replace with
The [Swagger](http://localhost:8080/swagger-ui/index.html) page shows all the available endpoints, and it could be used to test them..
You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger editor](https://editor.swagger.io).
##########
kogito-springboot-examples/decisiontable-springboot-example/README.md:
##########
@@ -35,7 +35,7 @@ java -jar target/decisiontable-springboot-example.jar
## OpenAPI (Swagger) documentation
[Specification at swagger.io](https://swagger.io/docs/specification/about/)
-You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger UI](https://editor.swagger.io).
+You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger](http://localhost:8080/swagger-ui/index.html).
Review Comment:
Pls replace with
The [Swagger](http://localhost:8080/swagger-ui/index.html) page shows all the available endpoints, and it could be used to test them..
You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger editor](https://editor.swagger.io).
##########
kogito-springboot-examples/ruleunit-springboot-example/README.md:
##########
@@ -31,7 +31,7 @@ java -jar target/ruleunit-springboot-example.jar
## OpenAPI (Swagger) documentation
[Specification at swagger.io](https://swagger.io/docs/specification/about/)
-You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger UI](https://editor.swagger.io).
+You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger](http://localhost:8080/swagger-ui/index.html).
Review Comment:
Pls replace with
The [Swagger](http://localhost:8080/swagger-ui/index.html) page shows all the available endpoints, and it could be used to test them..
You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger editor](https://editor.swagger.io).
##########
kogito-springboot-examples/rules-legacy-springboot-example/README.md:
##########
@@ -25,13 +25,13 @@ mvn clean compile spring-boot:run
```sh
mvn clean package
-java -jar target/ruleunit-springboot-example.jar
+java -jar target/rules-legacy-springboot-example.jar
```
## OpenAPI (Swagger) documentation
[Specification at swagger.io](https://swagger.io/docs/specification/about/)
-You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger UI](https://editor.swagger.io).
+You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger](http://localhost:8080/swagger-ui/index.html).
Review Comment:
Pls replace with
The [Swagger](http://localhost:8080/swagger-ui/index.html) page shows all the available endpoints, and it could be used to test them..
You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger editor](https://editor.swagger.io).
##########
kogito-springboot-examples/ruleunit-event-driven-springboot/README.md:
##########
@@ -70,16 +70,21 @@ mvn clean compile spring-boot:run
```
mvn clean package
-java -jar target/dmn-event-driven-springboot.jar
+java -jar target/ruleunit-event-driven-springboot.jar
```
or on Windows
```
mvn clean package
-java -jar target\dmn-event-driven-springboot.jar
+java -jar target\ruleunit-event-driven-springboot.jar
```
+## OpenAPI (Swagger) documentation
+[Specification at swagger.io](https://swagger.io/docs/specification/about/)
+
+You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger](http://localhost:8080/swagger-ui/index.html).
Review Comment:
Pls replace with
The [Swagger](http://localhost:8080/swagger-ui/index.html) page shows all the available endpoints, and it could be used to test them..
You can take a look at the [OpenAPI definition](http://localhost:8080/v3/api-docs) - automatically generated and included in this service - to determine all available operations exposed by this service. For easy readability you can visualize the OpenAPI definition file using a UI tool like for example available [Swagger editor](https://editor.swagger.io).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org