You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by km...@apache.org on 2008/02/20 02:37:25 UTC
svn commit: r629308 -
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java
Author: kmenard
Date: Tue Feb 19 17:37:21 2008
New Revision: 629308
URL: http://svn.apache.org/viewvc?rev=629308&view=rev
Log:
Replaced a nested exception with a simpler check.
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java?rev=629308&r1=629307&r2=629308&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java Tue Feb 19 17:37:21 2008
@@ -20,6 +20,7 @@
import static org.apache.tapestry.ioc.internal.util.Defense.notBlank;
import static org.apache.tapestry.ioc.internal.util.Defense.notNull;
import org.apache.tapestry.ioc.internal.util.TapestryException;
+import org.apache.tapestry.ioc.internal.util.InternalUtils;
import org.apache.tapestry.services.BindingFactory;
import org.apache.tapestry.services.BindingSource;
@@ -48,14 +49,8 @@
notNull(component, "component");
notBlank(defaultPrefix, "defaultPrefix");
- try
- {
- notBlank(expression, "expression");
- }
- catch (final Exception ex)
- {
- throw new TapestryException(ServicesMessages.emptyBinding(description), location, ex);
- }
+ if (InternalUtils.isBlank(expression))
+ throw new TapestryException(ServicesMessages.emptyBinding(description), location, null);
// Location might be null
RE: svn commit: r629308 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java
Posted by Kevin Menard <km...@servprise.com>.
Argh. Sorry for the headache. I signed up for both actually. I think
the problem may be that my apache.org address needs to be subscribed,
not my Servprise one. If it's not too much of a headache, could you
please manually subscribe that? If not, I'll have to download
Thunderbird and set up an apache.org profile just for the subscription
(the apache.org address forwards to my Servprise one), as I don't ever
use that address.
Thanks,
Kevin
--
Kevin Menard
Servprise International, Inc.
Remote reboot & power control for your network
www.servprise.com +1 508.892.3823 x308
> -----Original Message-----
> From: Jesse Kuhnert [mailto:jkuhnert@gmail.com]
> Sent: Wednesday, February 20, 2008 11:15 AM
> To: dev@tapestry.apache.org
> Subject: Re: svn commit: r629308 - /tapestry/tapestry5/trunk/tapestry-
>
core/src/main/java/org/apache/tapestry/internal/services/BindingSourceI
> mpl.java
>
> I think I was wrong about needing to subscribe to
> dev@tapestry.apache.org - it may be that you need to sign up for
> commits@tapestry.apache.org in order to bypass the manual email
> administration stuff.
>
> On Tue, Feb 19, 2008 at 8:37 PM, <km...@apache.org> wrote:
> > Author: kmenard
> > Date: Tue Feb 19 17:37:21 2008
> > New Revision: 629308
> >
> > URL: http://svn.apache.org/viewvc?rev=629308&view=rev
> > Log:
> > Replaced a nested exception with a simpler check.
> >
> > Modified:
> > tapestry/tapestry5/trunk/tapestry-
>
core/src/main/java/org/apache/tapestry/internal/services/BindingSourceI
> mpl.java
> >
> > Modified: tapestry/tapestry5/trunk/tapestry-
>
core/src/main/java/org/apache/tapestry/internal/services/BindingSourceI
> mpl.java
> > URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-
>
core/src/main/java/org/apache/tapestry/internal/services/BindingSourceI
> mpl.java?rev=629308&r1=629307&r2=629308&view=diff
> >
>
=======================================================================
> =======
> > --- tapestry/tapestry5/trunk/tapestry-
>
core/src/main/java/org/apache/tapestry/internal/services/BindingSourceI
> mpl.java (original)
> > +++ tapestry/tapestry5/trunk/tapestry-
>
core/src/main/java/org/apache/tapestry/internal/services/BindingSourceI
> mpl.java Tue Feb 19 17:37:21 2008
> > @@ -20,6 +20,7 @@
> > import static
> org.apache.tapestry.ioc.internal.util.Defense.notBlank;
> > import static
> org.apache.tapestry.ioc.internal.util.Defense.notNull;
> > import org.apache.tapestry.ioc.internal.util.TapestryException;
> > +import org.apache.tapestry.ioc.internal.util.InternalUtils;
> > import org.apache.tapestry.services.BindingFactory;
> > import org.apache.tapestry.services.BindingSource;
> >
> > @@ -48,14 +49,8 @@
> > notNull(component, "component");
> > notBlank(defaultPrefix, "defaultPrefix");
> >
> > - try
> > - {
> > - notBlank(expression, "expression");
> > - }
> > - catch (final Exception ex)
> > - {
> > - throw new
> TapestryException(ServicesMessages.emptyBinding(description),
location,
> ex);
> > - }
> > + if (InternalUtils.isBlank(expression))
> > + throw new
> TapestryException(ServicesMessages.emptyBinding(description),
location,
> null);
> >
> > // Location might be null
> >
> >
> >
> >
>
>
>
> --
> Jesse Kuhnert
> Tapestry / OGNL / Dojo team member/developer
>
> Open source based consulting work centered around
> dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: svn commit: r629308 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java
Posted by Jesse Kuhnert <jk...@gmail.com>.
I think I was wrong about needing to subscribe to
dev@tapestry.apache.org - it may be that you need to sign up for
commits@tapestry.apache.org in order to bypass the manual email
administration stuff.
On Tue, Feb 19, 2008 at 8:37 PM, <km...@apache.org> wrote:
> Author: kmenard
> Date: Tue Feb 19 17:37:21 2008
> New Revision: 629308
>
> URL: http://svn.apache.org/viewvc?rev=629308&view=rev
> Log:
> Replaced a nested exception with a simpler check.
>
> Modified:
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java?rev=629308&r1=629307&r2=629308&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/internal/services/BindingSourceImpl.java Tue Feb 19 17:37:21 2008
> @@ -20,6 +20,7 @@
> import static org.apache.tapestry.ioc.internal.util.Defense.notBlank;
> import static org.apache.tapestry.ioc.internal.util.Defense.notNull;
> import org.apache.tapestry.ioc.internal.util.TapestryException;
> +import org.apache.tapestry.ioc.internal.util.InternalUtils;
> import org.apache.tapestry.services.BindingFactory;
> import org.apache.tapestry.services.BindingSource;
>
> @@ -48,14 +49,8 @@
> notNull(component, "component");
> notBlank(defaultPrefix, "defaultPrefix");
>
> - try
> - {
> - notBlank(expression, "expression");
> - }
> - catch (final Exception ex)
> - {
> - throw new TapestryException(ServicesMessages.emptyBinding(description), location, ex);
> - }
> + if (InternalUtils.isBlank(expression))
> + throw new TapestryException(ServicesMessages.emptyBinding(description), location, null);
>
> // Location might be null
>
>
>
>
--
Jesse Kuhnert
Tapestry / OGNL / Dojo team member/developer
Open source based consulting work centered around
dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org