You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Chug Rolke <cr...@redhat.com> on 2012/12/12 20:29:10 UTC
Review Request: QPID-1726 ASF licensed, QPID hosted store
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8556/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Gordon Sim, and Kim van der Riet.
Description
-------
This patch installs the store mission code and gets it to compile. Remaining installments to qpid-1726 will port the tests, docs, and tools.
The changes to qpid proper are all contained in the first four files on the first page of diffs. The rest of the diff is code taken from the old repo being installed as new files.
The cmake code is contained in its own file making changes to CMakeLists.txt minimal. Another source file, finddb.cmake, locates the bdb code. Without bdb the legacystore compilation is skipped.
All new files received Apache License 2.0 and retained any copyrights they had in the previous repo.
This addresses bug QPID-1726.
https://issues.apache.org/jira/browse/QPID-1726
Diffs
-----
trunk/qpid/cpp/src/CMakeLists.txt 1420897
trunk/qpid/cpp/src/finddb.cmake PRE-CREATION
trunk/qpid/cpp/src/legacystore.cmake PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BindingDbt.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BindingDbt.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BufferValue.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BufferValue.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/Cursor.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/DataTokenImpl.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/DataTokenImpl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdDbt.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdDbt.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdSequence.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdSequence.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/JournalImpl.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/JournalImpl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/MessageStoreImpl.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/MessageStoreImpl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/PreparedTransaction.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/PreparedTransaction.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/StoreException.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/StorePlugin.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/TxnCtxt.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/TxnCtxt.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/aio.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/aio.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/aio_callback.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/cvar.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/cvar.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/data_tok.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/data_tok.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/deq_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/deq_rec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/deq_rec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_map.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_map.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_rec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_rec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enums.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/fcntl.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/fcntl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/file_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jcfg.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jcntl.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jcntl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jdir.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jdir.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jerrno.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jerrno.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jexception.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jexception.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jinf.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jinf.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jrec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jrec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lp_map.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lp_map.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lpmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lpmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/pmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/pmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rcvdat.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rec_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rec_tail.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rfc.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rfc.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rrfc.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rrfc.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/slock.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/slock.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/smutex.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/smutex.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/time_ns.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/time_ns.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_map.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_map.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_rec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_rec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wrfc.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wrfc.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/management-schema.xml PRE-CREATION
trunk/qpid/cpp/src/versions.cmake 1420897
Diff: https://reviews.apache.org/r/8556/diff/
Testing
-------
Thanks,
Chug Rolke
Re: Review Request: QPID-1726 ASF licensed, QPID hosted store
Posted by Chug Rolke <cr...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8556/
-----------------------------------------------------------
(Updated Dec. 12, 2012, 7:29 p.m.)
Review request for qpid, Andrew Stitcher, Gordon Sim, and Kim van der Riet.
Description
-------
This patch installs the store mission code and gets it to compile. Remaining installments to qpid-1726 will port the tests, docs, and tools.
The changes to qpid proper are all contained in the first four files on the first page of diffs. The rest of the diff is code taken from the old repo being installed as new files.
The cmake code is contained in its own file making changes to CMakeLists.txt minimal. Another source file, finddb.cmake, locates the bdb code. Without bdb the legacystore compilation is skipped.
All new files received Apache License 2.0 and retained any copyrights they had in the previous repo.
This addresses bug QPID-1726.
https://issues.apache.org/jira/browse/QPID-1726
Diffs
-----
trunk/qpid/cpp/src/CMakeLists.txt 1420897
trunk/qpid/cpp/src/finddb.cmake PRE-CREATION
trunk/qpid/cpp/src/legacystore.cmake PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BindingDbt.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BindingDbt.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BufferValue.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/BufferValue.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/Cursor.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/DataTokenImpl.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/DataTokenImpl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdDbt.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdDbt.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdSequence.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/IdSequence.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/JournalImpl.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/JournalImpl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/MessageStoreImpl.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/MessageStoreImpl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/PreparedTransaction.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/PreparedTransaction.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/StoreException.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/StorePlugin.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/TxnCtxt.h PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/TxnCtxt.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/aio.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/aio.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/aio_callback.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/cvar.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/cvar.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/data_tok.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/data_tok.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/deq_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/deq_rec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/deq_rec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_map.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_map.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_rec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enq_rec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/enums.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/fcntl.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/fcntl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/file_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jcfg.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jcntl.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jcntl.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jdir.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jdir.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jerrno.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jerrno.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jexception.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jexception.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jinf.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jinf.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jrec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/jrec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lp_map.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lp_map.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lpmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/lpmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/pmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/pmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rcvdat.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rec_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rec_tail.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rfc.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rfc.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rrfc.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/rrfc.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/slock.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/slock.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/smutex.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/smutex.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/time_ns.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/time_ns.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_hdr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_map.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_map.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_rec.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/txn_rec.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wmgr.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wmgr.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wrfc.hpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/jrnl/wrfc.cpp PRE-CREATION
trunk/qpid/cpp/src/qpid/legacystore/management-schema.xml PRE-CREATION
trunk/qpid/cpp/src/versions.cmake 1420897
Diff: https://reviews.apache.org/r/8556/diff/
Testing
-------
Thanks,
Chug Rolke