[GitHub] [commons-text] garydgregory commented on a change in pull request #225: TEXT-202 - Extract duplicate code

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616587084



##########
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##########
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
             buffer[size++] = 't';
             buffer[size++] = 'r';
             buffer[size++] = 'u';
-            buffer[size++] = 'e';
         } else {
             ensureCapacity(size + 5);
             buffer[size++] = 'f';
             buffer[size++] = 'a';
             buffer[size++] = 'l';
             buffer[size++] = 's';
-            buffer[size++] = 'e';
         }
+        buffer[size++] = 'e';

Review comment:
       I agree with @kinow, you have to think about maintainers reading the code, not just applying changes mechanically.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org