You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 22:06:26 UTC
[GitHub] [airflow] kaxil opened a new pull request #15997: Add Docs for ``default_pool`` slots
kaxil opened a new pull request #15997:
URL: https://github.com/apache/airflow/pull/15997
Until now this was undocumented, however it was used in:
https://github.com/apache/airflow/blob/aa4713e43f92d3e4c68c3ad00e2d44caaf29aafe/airflow/utils/db.py#L75
This was done in 1.10.4 in https://github.com/apache/airflow/commit/2c99ec624bd66e9fa38e9f0087d46ef4d7f05aec
commit. This commit also updates the name from `non_pooled_task_slot_count` to `default_pool_task_slot_count` as
this is what it actually does.
This will help Helm Chart users as mentioned in https://github.com/airflow-helm/charts/issues/211#issuecomment-846278780
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15997:
URL: https://github.com/apache/airflow/pull/15997#issuecomment-846366240
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #15997:
URL: https://github.com/apache/airflow/pull/15997#discussion_r637359766
##########
File path: airflow/utils/db.py
##########
@@ -72,7 +72,7 @@ def add_default_pool_if_not_exists(session=None):
if not Pool.get_pool(Pool.DEFAULT_POOL_NAME, session=session):
default_pool = Pool(
pool=Pool.DEFAULT_POOL_NAME,
- slots=conf.getint(section='core', key='non_pooled_task_slot_count', fallback=128),
+ slots=conf.getint(section='core', key='default_pool_task_slot_count', fallback=128),
Review comment:
```suggestion
slots=conf.getint(section='core', key='default_pool_task_slot_count'),
```
##########
File path: UPDATING.md
##########
@@ -72,6 +72,16 @@ https://developers.google.com/style/inclusive-documentation
-->
+### Default Task Pools Slots can be updated using ``[core] default_pool_task_slot_count``
Review comment:
```suggestion
### Default Task Pools Slots can be set using ``[core] default_pool_task_slot_count``
```
I think this better reflects its behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15997:
URL: https://github.com/apache/airflow/pull/15997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andormarkus commented on pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
andormarkus commented on pull request #15997:
URL: https://github.com/apache/airflow/pull/15997#issuecomment-846305710
Hi All,
Based on my testing changing the of `AIRFLOW__CORE__NON_POOLED_TASK_SLOT_COUNT` will not update the size of the pool. On a running environment of you want to resize your pool you need to delete the default pool first and redeploy your helm chart to change the size of the pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andormarkus commented on pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
andormarkus commented on pull request #15997:
URL: https://github.com/apache/airflow/pull/15997#issuecomment-846393124
Hi All,
Do you see the possibility to extend `upgradedb` with `update_default_pool_if_exists`?
With this extension user could update default pool size not just set on creation.
I'm more than happy submit a PR if I get guidance regarding the expected implementation.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #15997:
URL: https://github.com/apache/airflow/pull/15997#issuecomment-846308256
> Hi All,
>
> Based on my testing changing the of `AIRFLOW__CORE__NON_POOLED_TASK_SLOT_COUNT` will not update the size of the pool. On a running environment of you want to resize your pool you need to delete the default pool first and redeploy your helm chart to change the size of the pool.
Hi @andormarkus That is expected behaviour, I have updated the description and guide accordingly.
-----
### Default Task Pools Slots can be updated using ``[core] default_pool_task_slot_count``
By default tasks are running in `default_pool`. `default_pool` is initialized with `128` slots and user can change the
number of slots through UI/CLI/API for an existing deployment.
For new deployments, you can use `default_pool_task_slot_count` setting in `[core]` section. This setting would
not have any effect in an existing deployment where the ``default_pool`` already exists.
Previously this was controlled by `non_pooled_task_slot_count` in `[core]` section, which was not documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15997:
URL: https://github.com/apache/airflow/pull/15997#issuecomment-846308256
> Hi All,
>
> Based on my testing changing the of `AIRFLOW__CORE__NON_POOLED_TASK_SLOT_COUNT` will not update the size of the pool. On a running environment of you want to resize your pool you need to delete the default pool first and redeploy your helm chart to change the size of the pool.
Hi @andormarkus That is expected behaviour, I have updated the description and guide accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15997: Add Docs for ``default_pool`` slots
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15997:
URL: https://github.com/apache/airflow/pull/15997#issuecomment-846322897
[The Workflow run](https://github.com/apache/airflow/actions/runs/865545144) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org