[GitHub] davisp commented on a change in pull request #886: Fix cluster upgrades when deploying ddoc_cache

[gi...@git.apache.org]

davisp commented on a change in pull request #886: Fix cluster upgrades when deploying ddoc_cache
URL: https://github.com/apache/couchdb/pull/886#discussion_r143801114
 
 

 ##########
 File path: src/ddoc_cache/src/ddoc_cache_lru.erl
 ##########
 @@ -143,11 +146,11 @@ handle_call(Msg, _From, St) ->
 
 
 handle_cast({evict, DbName}, St) ->
-    gen_server:abcast(mem3:nodes(), ?MODULE, {do_evict, DbName}),
+    gen_server:abcast(mem3:nodes(), ?OPENER, {do_evict, DbName}),
     {noreply, St};
 
 handle_cast({refresh, DbName, DDocIds}, St) ->
-    gen_server:abcast(mem3:nodes(), ?MODULE, {do_refresh, DbName, DDocIds}),
+    gen_server:abcast(mem3:nodes(), ?OPENER, {do_evict, DbName, DDocIds}),
 
 Review comment:
   Yes, that's the fix.
   
   https://github.com/apache/couchdb/blob/master/src/ddoc_cache/src/ddoc_cache_opener.erl#L47-L55
   
   Its reverting the message passing protcol to match the old version. For old nodes this means they continue to behave the same. For new nodes, the ddoc_cache_opener module exists solely to forward and translate the old style messages to new style. My mistake was just not realizing that ddoc_cache_lru wouldn't be silently ignored by the old version (because the ets_lru process exists).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services