You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2017/11/14 12:08:03 UTC
svn commit: r1815208 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml
Author: markt
Date: Tue Nov 14 12:08:02 2017
New Revision: 1815208
URL: http://svn.apache.org/viewvc?rev=1815208&view=rev
Log:
Add a SHA-256 hash
Modified:
tomcat/trunk/build.xml
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/build.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1815208&r1=1815207&r2=1815208&view=diff
==============================================================================
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Tue Nov 14 12:08:02 2017
@@ -2946,13 +2946,16 @@ Read the Building page on the Apache Tom
<local name="filename" />
<local name="md5value" />
<local name="sha1value" />
+ <local name="sha256value" />
<basename file="@{file}" property="filename" />
<checksum algorithm="MD5" file="@{file}" property="md5value" />
<checksum algorithm="SHA-1" file="@{file}" property="sha1value" />
+ <checksum algorithm="SHA-256" file="@{file}" property="sha256value" />
<echo file="@{file}.md5" message="${md5value}${md5sum.binary-prefix}${filename}" />
<echo file="@{file}.sha1" message="${sha1value}${md5sum.binary-prefix}${filename}" />
+ <echo file="@{file}.sha256" message="${sha256value}${md5sum.binary-prefix}${filename}" />
<antcall target="sign" >
<param name="file" value="@{file}" />
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1815208&r1=1815207&r2=1815208&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Nov 14 12:08:02 2017
@@ -177,6 +177,10 @@
<bug>61598</bug>: Update the Windows installer to search the new (as of
Java 9) registry locations when looking for a JRE. (markt)
</fix>
+ <add>
+ Add generatation of a SHA-256 hash for release artefacts to the build
+ script. (markt)
+ </add>
</changelog>
</subsection>
</section>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1815208 - in /tomcat/trunk: build.xml
webapps/docs/changelog.xml
Posted by Mark Thomas <ma...@apache.org>.
On 14/11/17 12:13, Konstantin Kolinko wrote:
> 2017-11-14 15:08 GMT+03:00 <ma...@apache.org>:
>> Author: markt
>> Date: Tue Nov 14 12:08:02 2017
>> New Revision: 1815208
>>
>> URL: http://svn.apache.org/viewvc?rev=1815208&view=rev
>> Log:
>> Add a SHA-256 hash
>>
>> Modified:
>> tomcat/trunk/build.xml
>> tomcat/trunk/webapps/docs/changelog.xml
>>
>> Modified: tomcat/trunk/build.xml
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1815208&r1=1815207&r2=1815208&view=diff
>> ==============================================================================
>> --- tomcat/trunk/build.xml (original)
>> +++ tomcat/trunk/build.xml Tue Nov 14 12:08:02 2017
>> @@ -2946,13 +2946,16 @@ Read the Building page on the Apache Tom
>> <local name="filename" />
>> <local name="md5value" />
>> <local name="sha1value" />
>> + <local name="sha256value" />
>>
>> <basename file="@{file}" property="filename" />
>> <checksum algorithm="MD5" file="@{file}" property="md5value" />
>> <checksum algorithm="SHA-1" file="@{file}" property="sha1value" />
>> + <checksum algorithm="SHA-256" file="@{file}" property="sha256value" />
>>
>> <echo file="@{file}.md5" message="${md5value}${md5sum.binary-prefix}${filename}" />
>> <echo file="@{file}.sha1" message="${sha1value}${md5sum.binary-prefix}${filename}" />
>> + <echo file="@{file}.sha256" message="${sha256value}${md5sum.binary-prefix}${filename}" />
>>
>> <antcall target="sign" >
>> <param name="file" value="@{file}" />
>>
>> Modified: tomcat/trunk/webapps/docs/changelog.xml
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1815208&r1=1815207&r2=1815208&view=diff
>> ==============================================================================
>> --- tomcat/trunk/webapps/docs/changelog.xml (original)
>> +++ tomcat/trunk/webapps/docs/changelog.xml Tue Nov 14 12:08:02 2017
>> @@ -177,6 +177,10 @@
>> <bug>61598</bug>: Update the Windows installer to search the new (as of
>> Java 9) registry locations when looking for a JRE. (markt)
>> </fix>
>> + <add>
>> + Add generatation of a SHA-256 hash for release artefacts to the build
>
> s/generatation/generation
I'll get that fixed.
> Last time I was reading ASF documentation on releases, SHA-512 was the
> recommended sha2 length.
Good point. I'll switch this to SHA-512.
Mark
>
> http://www.apache.org/dev/release-signing.html#sha-checksum
> http://www.apache.org/dev/release-signing.html#sha1
>
> A well known project that uses SHA-512 is Apache Ant,
> http://ant.apache.org/bindownload.cgi
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1815208 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml
Posted by Konstantin Kolinko <kn...@gmail.com>.
2017-11-14 15:08 GMT+03:00 <ma...@apache.org>:
> Author: markt
> Date: Tue Nov 14 12:08:02 2017
> New Revision: 1815208
>
> URL: http://svn.apache.org/viewvc?rev=1815208&view=rev
> Log:
> Add a SHA-256 hash
>
> Modified:
> tomcat/trunk/build.xml
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/build.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1815208&r1=1815207&r2=1815208&view=diff
> ==============================================================================
> --- tomcat/trunk/build.xml (original)
> +++ tomcat/trunk/build.xml Tue Nov 14 12:08:02 2017
> @@ -2946,13 +2946,16 @@ Read the Building page on the Apache Tom
> <local name="filename" />
> <local name="md5value" />
> <local name="sha1value" />
> + <local name="sha256value" />
>
> <basename file="@{file}" property="filename" />
> <checksum algorithm="MD5" file="@{file}" property="md5value" />
> <checksum algorithm="SHA-1" file="@{file}" property="sha1value" />
> + <checksum algorithm="SHA-256" file="@{file}" property="sha256value" />
>
> <echo file="@{file}.md5" message="${md5value}${md5sum.binary-prefix}${filename}" />
> <echo file="@{file}.sha1" message="${sha1value}${md5sum.binary-prefix}${filename}" />
> + <echo file="@{file}.sha256" message="${sha256value}${md5sum.binary-prefix}${filename}" />
>
> <antcall target="sign" >
> <param name="file" value="@{file}" />
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1815208&r1=1815207&r2=1815208&view=diff
> ==============================================================================
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Tue Nov 14 12:08:02 2017
> @@ -177,6 +177,10 @@
> <bug>61598</bug>: Update the Windows installer to search the new (as of
> Java 9) registry locations when looking for a JRE. (markt)
> </fix>
> + <add>
> + Add generatation of a SHA-256 hash for release artefacts to the build
s/generatation/generation
Last time I was reading ASF documentation on releases, SHA-512 was the
recommended sha2 length.
http://www.apache.org/dev/release-signing.html#sha-checksum
http://www.apache.org/dev/release-signing.html#sha1
A well known project that uses SHA-512 is Apache Ant,
http://ant.apache.org/bindownload.cgi
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org