You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "TrafficServer Bot (JIRA)" <ji...@apache.org> on 2013/01/30 20:39:13 UTC
[jira] [Commented] (TS-1674) TSStatIntDecrement is broken
[ https://issues.apache.org/jira/browse/TS-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566824#comment-13566824 ]
TrafficServer Bot commented on TS-1674:
---------------------------------------
Commit 6d573ce581846663508067766a6960b77d2cc6aa from [~briang]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=6d573ce ]
TS-1674: TSStatIntDecrement is broken: logic is flawed
> TSStatIntDecrement is broken
> ----------------------------
>
> Key: TS-1674
> URL: https://issues.apache.org/jira/browse/TS-1674
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Reporter: Brian Geffon
> Assignee: Brian Geffon
>
> ATS keeps a thread-local copy of the stat value and aggregates it periodically and on demand when stats are being collected. However the decrement function doesn't let a value go negative. So in a thread that has not incremented this stat previously, the decrement call "fails". This negative value check is logically flawed as it doesn't account for the per-thread distribution of the stats.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira