[GitHub] [hudi] danny0405 commented on a diff in pull request #8501: [HUDI-6103] Validate required columns when fetching required positions

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8501:
URL: https://github.com/apache/hudi/pull/8501#discussion_r1172043586


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadTableState.java:
##########
@@ -85,7 +86,7 @@ public int getOperationPos() {
   public int[] getRequiredPositions() {
     final List<String> fieldNames = rowType.getFieldNames();
     return requiredRowType.getFieldNames().stream()
-        .map(fieldNames::indexOf)
+        .map(f -> getIdxOfFieldOrElseThrow(f, fieldNames))
         .mapToInt(i -> i)

Review Comment:
   We should avoid unnecessary check on the code when it never happens.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org