You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/09/08 22:48:04 UTC
[native-toolchain-CR] IMPALA-11515: Do not use --load-average if ninja is installed
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18957
Change subject: IMPALA-11515: Do not use --load-average if ninja is installed
......................................................................
IMPALA-11515: Do not use --load-average if ninja is installed
Kudu will use ninja if it is installed. Since ninja
does not support --load-average, the Kudu build will
fail if it runs on a machine with ninja installed.
This detects whether ninja is installed and does
not use --load-average. This only applies to one
step of the Kudu build. The usual method of building
native-toolchain does not have ninja installed, so
this is an unusual case.
Testing:
- Tested the logic by hand inside a docker image. Tried
without ninja installed, then installed ninja and tried
again.
Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
---
M source/kudu/build.sh
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/57/18957/1
--
To view, visit http://gerrit.cloudera.org:8080/18957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
Gerrit-Change-Number: 18957
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-11515: Do not use --load-average if ninja is installed
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18957 )
Change subject: IMPALA-11515: Do not use --load-average if ninja is installed
......................................................................
Patch Set 1: Verified+1
The regular toolchain build succeeded. Since this is not changing any toolchain artifacts, I will not bump the toolchain on the Impala side. It will just become part of whatever comes next.
--
To view, visit http://gerrit.cloudera.org:8080/18957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
Gerrit-Change-Number: 18957
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 15:28:46 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11515: Do not use --load-average if ninja is installed
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18957 )
Change subject: IMPALA-11515: Do not use --load-average if ninja is installed
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
Gerrit-Change-Number: 18957
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 22:49:07 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11515: Do not use --load-average if ninja is installed
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18957 )
Change subject: IMPALA-11515: Do not use --load-average if ninja is installed
......................................................................
IMPALA-11515: Do not use --load-average if ninja is installed
Kudu will use ninja if it is installed. Since ninja
does not support --load-average, the Kudu build will
fail if it runs on a machine with ninja installed.
This detects whether ninja is installed and does
not use --load-average. This only applies to one
step of the Kudu build. The usual method of building
native-toolchain does not have ninja installed, so
this is an unusual case.
Testing:
- Tested the logic by hand inside a docker image. Tried
without ninja installed, then installed ninja and tried
again.
Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
Reviewed-on: http://gerrit.cloudera.org:8080/18957
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M source/kudu/build.sh
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Wenzhe Zhou: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
Gerrit-Change-Number: 18957
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-11515: Do not use --load-average if ninja is installed
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18957 )
Change subject: IMPALA-11515: Do not use --load-average if ninja is installed
......................................................................
Patch Set 1: Code-Review+2
Carry +1 from Michael.
--
To view, visit http://gerrit.cloudera.org:8080/18957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
Gerrit-Change-Number: 18957
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 02:03:21 +0000
Gerrit-HasComments: No