You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "FredrikAnderson (via GitHub)" <gi...@apache.org> on 2024/03/04 21:09:44 UTC

[PR] [MSITE-945] Remove dependency on Commons IO [maven-site-plugin]

FredrikAnderson opened a new pull request, #174:
URL: https://github.com/apache/maven-site-plugin/pull/174

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ x] Each commit in the pull request should have a meaningful subject line and body.
    - [ x] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   
   Straightforward fix, deleted dependency and module is still verified OK.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSITE-945] Remove dependency on Commons IO [maven-site-plugin]

Posted by "FredrikAnderson (via GitHub)" <gi...@apache.org>.
FredrikAnderson commented on PR #174:
URL: https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1995152481

   Hi again,
   
   Now I have updated with code in a branch in my fork at:
   https://github.com/FredrikAnderson/maven-site-plugin/tree/feature/msite-945
   
   Since I needed to do an extra commit I removed my feature-branch in my
   fork, which closed the PR in "main" repo.
   
   Please propose how to proceed.
   
   Fredrik
   
   
   
   On Mon, Mar 4, 2024 at 10:30 PM Fredrik Anderson ***@***.***>
   wrote:
   
   > Ah, well now I see. Will look into it and come back.
   >
   > Thx for now.
   >
   > On Mon, Mar 4, 2024 at 10:27 PM Fredrik Anderson ***@***.***>
   > wrote:
   >
   >> Maybe I missed something here then; removed the dependency and thought
   >> that there will be compilation or verification error if something broke,
   >> but it didn't so then thought that nothing is dependent on commons-io
   >> classes. Or did I miss something, can you elaborate?
   >>
   >> On Mon, Mar 4, 2024 at 10:22 PM Michael Osipov ***@***.***>
   >> wrote:
   >>
   >>> But what about the actual code?
   >>>
   >>> —
   >>> Reply to this email directly, view it on GitHub
   >>> <https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977479509>,
   >>> or unsubscribe
   >>> <https://github.com/notifications/unsubscribe-auth/AGWA5SXBWLJC2MK6ALT3B33YWTQYNAVCNFSM6AAAAABEF5SH7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQ3TSNJQHE>
   >>> .
   >>> You are receiving this because you authored the thread.Message ID:
   >>> ***@***.***>
   >>>
   >>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSITE-945] Remove dependency on Commons IO [maven-site-plugin]

Posted by "FredrikAnderson (via GitHub)" <gi...@apache.org>.
FredrikAnderson commented on PR #174:
URL: https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977492846

   Ah, well now I see. Will look into it and come back.
   
   Thx for now.
   
   On Mon, Mar 4, 2024 at 10:27 PM Fredrik Anderson ***@***.***>
   wrote:
   
   > Maybe I missed something here then; removed the dependency and thought
   > that there will be compilation or verification error if something broke,
   > but it didn't so then thought that nothing is dependent on commons-io
   > classes. Or did I miss something, can you elaborate?
   >
   > On Mon, Mar 4, 2024 at 10:22 PM Michael Osipov ***@***.***>
   > wrote:
   >
   >> But what about the actual code?
   >>
   >> —
   >> Reply to this email directly, view it on GitHub
   >> <https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977479509>,
   >> or unsubscribe
   >> <https://github.com/notifications/unsubscribe-auth/AGWA5SXBWLJC2MK6ALT3B33YWTQYNAVCNFSM6AAAAABEF5SH7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQ3TSNJQHE>
   >> .
   >> You are receiving this because you authored the thread.Message ID:
   >> ***@***.***>
   >>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSITE-945] Remove dependency on Commons IO [maven-site-plugin]

Posted by "FredrikAnderson (via GitHub)" <gi...@apache.org>.
FredrikAnderson commented on PR #174:
URL: https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977489455

   Maybe I missed something here then; removed the dependency and thought that
   there will be compilation or verification error if something broke, but it
   didn't so then thought that nothing is dependent on commons-io classes. Or
   did I miss something, can you elaborate?
   
   On Mon, Mar 4, 2024 at 10:22 PM Michael Osipov ***@***.***>
   wrote:
   
   > But what about the actual code?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977479509>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGWA5SXBWLJC2MK6ALT3B33YWTQYNAVCNFSM6AAAAABEF5SH7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQ3TSNJQHE>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSITE-945] Remove dependency on Commons IO [maven-site-plugin]

Posted by "FredrikAnderson (via GitHub)" <gi...@apache.org>.
FredrikAnderson closed pull request #174: [MSITE-945] Remove dependency on Commons IO
URL: https://github.com/apache/maven-site-plugin/pull/174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSITE-945] Remove dependency on Commons IO [maven-site-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #174:
URL: https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977479509

   But what about the actual code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org