[GitHub] [cassandra] blerer commented on a diff in pull request #2668: CASSANDRA-18322 trunk emit warning for usage of unqualfied prepared statements only when necessary

["blerer (via GitHub)" <gi...@apache.org>]

blerer commented on code in PR #2668:
URL: https://github.com/apache/cassandra/pull/2668#discussion_r1319546958


##########
src/java/org/apache/cassandra/cql3/CQLStatement.java:
##########
@@ -99,6 +99,11 @@ default public boolean hasConditions()
         return false;
     }
 
+    default public boolean shouldUseFullyQualifiedTableName()

Review Comment:
   It will be nice to have some Javadoc here so to explain the role of this method.



##########
src/java/org/apache/cassandra/cql3/CQLStatement.java:
##########
@@ -99,6 +99,11 @@ default public boolean hasConditions()
         return false;
     }
 
+    default public boolean eligibleAsPreparedStatement()

Review Comment:
   nit: It would be nice to have some Javadoc to explain the role of this method and how it is used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org