You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2017/04/19 20:27:43 UTC
Review Request 58541: GEODE-576 & GEODE-516 Flaky test:
GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58541/
-----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
Bugs: GEODE-516 and GEODE-576
https://issues.apache.org/jira/browse/GEODE-516
https://issues.apache.org/jira/browse/GEODE-576
Repository: geode
Description
-------
Replaced pauses with Awaitilty. Modified asyncs to use the DUnit blackboard to synchronize their actions for repeatable behavior. Cleaned up static locks to allow their reuse in other tests or in repeating the same test.
Diffs
-----
geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java e0bbde06ba2ce8e8db55627920ee6cf23e4badb2
Diff: https://reviews.apache.org/r/58541/diff/1/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 58541: GEODE-576 & GEODE-516 Flaky test:
GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58541/#review172557
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On April 19, 2017, 8:27 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58541/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 8:27 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
>
>
> Bugs: GEODE-516 and GEODE-576
> https://issues.apache.org/jira/browse/GEODE-516
> https://issues.apache.org/jira/browse/GEODE-576
>
>
> Repository: geode
>
>
> Description
> -------
>
> Replaced pauses with Awaitility. Modified asyncs to use the DUnit blackboard to synchronize their actions for repeatable behavior. Cleaned up static locks to allow their reuse in other tests or in repeating the same test.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java e0bbde06ba2ce8e8db55627920ee6cf23e4badb2
>
>
> Diff: https://reviews.apache.org/r/58541/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 58541: GEODE-576 & GEODE-516 Flaky test:
GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58541/#review172534
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On April 19, 2017, 8:27 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58541/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 8:27 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
>
>
> Bugs: GEODE-516 and GEODE-576
> https://issues.apache.org/jira/browse/GEODE-516
> https://issues.apache.org/jira/browse/GEODE-576
>
>
> Repository: geode
>
>
> Description
> -------
>
> Replaced pauses with Awaitility. Modified asyncs to use the DUnit blackboard to synchronize their actions for repeatable behavior. Cleaned up static locks to allow their reuse in other tests or in repeating the same test.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java e0bbde06ba2ce8e8db55627920ee6cf23e4badb2
>
>
> Diff: https://reviews.apache.org/r/58541/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>