You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 22:57:10 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #10289: fix: saving custom CSS correctly from dashboard editor
rusackas opened a new pull request #10289:
URL: https://github.com/apache/incubator-superset/pull/10289
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
A fix was made to the `save as` modal that wasn't applied to the method called by the `save as` button after editing the custom CSS. This fixes the parameter name (which was changed to avoid a collision with Emotion props).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #10102
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] avicenteg commented on pull request #10289: fix: saving custom CSS correctly from dashboard editor
Posted by GitBox <gi...@apache.org>.
avicenteg commented on pull request #10289:
URL: https://github.com/apache/incubator-superset/pull/10289#issuecomment-712809729
Hello,
Altough it save the changes, when closing the dashboard and reopening it, it doesn't charge the custom CSS.
It is happening to anyone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] avicenteg commented on pull request #10289: fix: saving custom CSS correctly from dashboard editor
Posted by GitBox <gi...@apache.org>.
avicenteg commented on pull request #10289:
URL: https://github.com/apache/incubator-superset/pull/10289#issuecomment-717095835
@rusackas @junlincc
Can you check my previous comment?
When I save my changes in the custom CSS, it is stored, but not charged when rendering again the dashboard.
For example:
I refresh the page and:
If I inspect the page, it is like if the css template were overwrited by the default css.
Do you have any clue of what can be happening?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] avicenteg commented on pull request #10289: fix: saving custom CSS correctly from dashboard editor
Posted by GitBox <gi...@apache.org>.
avicenteg commented on pull request #10289:
URL: https://github.com/apache/incubator-superset/pull/10289#issuecomment-722327991
@rusackas I'll try your advice. Also I'll check if I can find a way for loading the custom css first, if I find some solution I'll let you know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10289: fix: saving custom CSS correctly from dashboard editor
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10289:
URL: https://github.com/apache/incubator-superset/pull/10289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] PowerPlop commented on pull request #10289: fix: saving custom CSS correctly from dashboard editor
Posted by GitBox <gi...@apache.org>.
PowerPlop commented on pull request #10289:
URL: https://github.com/apache/incubator-superset/pull/10289#issuecomment-709360544
When editing a dashboard and applying a custom css template, the change is not saved when pressing 'save changes' . You need to explicitly select 'Save As' + 'Overwrite' to keep the css change. Is this expected behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org