You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Bryan Cutler <cu...@gmail.com> on 2015/05/08 21:17:31 UTC

Review Request 33993: Create a mainrepoid field in repoinfo.xml to indicate which repo base url will be updated

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33993/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-10945
    https://issues.apache.org/jira/browse/AMBARI-10945


Repository: ambari


Description
-------

During the Ambari upgrade process, StackUpgradeUtil.updateLocalRepo() attempts to update the base URL of a repository with the assumption that the repoid will be in the form "stackName-stackVersion." If the repoid does not follow this, there is an error and the upgrade process can not continue.
I propose that we add an optional field in repoinfo.xml that can define a "main" repository to be updated so that there is no assumption of the repoid. If this field is not provided, then it will fall back to updating a repoid with "stackName-stackVersion."


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4b88aff 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 2aa89cc 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java eff063b 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 8c629ca 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 9804bca 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 804aa60 

Diff: https://reviews.apache.org/r/33993/diff/


Testing
-------

Updated unit test UpgradeCatalog200Test.testPersistHDPRepo()
All unit tests passed


Thanks,

Bryan Cutler