You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/02/06 19:47:14 UTC

[GitHub] incubator-brooklyn pull request: Mobile app

GitHub user sjcorbett opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/508

    Mobile app

    Supercedes #130. All mobile-related code is in a mobile-app project in sandbox. With the additional adjustments it is deployable alongside the existing Brooklyn UI. 
    
    The project incorporates a number of third party libraries. All of them are published under the MIT license. Do I need to acknowledge them in any other files?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/incubator-brooklyn mobile-app

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #508
    
----
commit 0df6929d8587a88945bd2712abbeb24847a34a9f
Author: Angel Tomala-Reyes <ae...@nyc.rr.com>
Date:   2014-08-22T19:18:37Z

    First iteration brooklyn web mobile app.

commit 230be65c979c9b4cc40b870f3eb657977b8944ad
Author: Angel Tomala-Reyes <ae...@nyc.rr.com>
Date:   2014-08-22T20:01:01Z

    Corrected spelling mistake in translation file
    Increased refresh frequency to 10 secs
    Corrected a translation problem in index.m.html

commit 123426687c1a7d28340dbffbe98da063c2b16629
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-02-06T17:05:37Z

    Move mobile app to sandbox

commit d9850a168f1b762b78ca42ac622a76f77c8baf07
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-02-06T17:05:59Z

    Merge remote-tracking branch 'apache/master' into mobile-app

commit c5551b7d354cf1745b2d1cf9e5f66f401a6cce4e
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-02-06T18:29:22Z

    Fix up mobile app
    
    * relative paths in HTML and js
    * alter group ID
    * add to sandbox pom along with cassandra-snitch
    * swaps Cloudsoft logos for Brooklyn

commit 9b07292a30db09f3e6294ab722c6e0850f241208
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-02-06T18:44:32Z

    Delete almost all Angular translations
    
    We can add them back should we ever support the mobile app properly.

commit 98e489dbd70556c87d9ff4b2cfef6cdbb12b4667
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-02-06T18:44:53Z

    Delete unused mobile-app libraries

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Mobile app

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/508


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Mobile app

Posted by sjcorbett <gi...@git.apache.org>.

Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/508#issuecomment-73290866
  
    P.S. I made no attempt to address any of the comments outstanding on #130.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Mobile app

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/508#issuecomment-87343509
  
    looks good to me, apart from a few rat failures which i'll add.
    
    would be nice to have a `--wars xxx` option on the cli and a README.md describing how to use it.  on the backlog...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---