You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/01 05:25:10 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7491: Fix the warning found by https://github.com/apache/incubator-nuttx/pull/7391
pkarashchenko commented on code in PR #7491:
URL: https://github.com/apache/incubator-nuttx/pull/7491#discussion_r1010082175
##########
include/nuttx/usb/usb.h:
##########
@@ -65,10 +65,10 @@
#define MSBYTE(u16) ((u16) >> 8) /* Get MS byte from uint16_t */
#define LSBYTE(u16) ((u16) & 0xff) /* Get LS byte from uint16_t */
-#define GETUINT16(p) (((uint16_t)p[1] << 8) | (uint16_t)p[0])
-#define GETUINT32(p) (((uint32_t)p[3] << 24) | \
- ((uint32_t)p[2] << 16) | \
- ((uint32_t)p[1] << 8) | (uint32_t)p[0])
+#define GETUINT16(p) ((uint16_t)((p[1] << 8) | p[0]))
Review Comment:
I think that compiler warning is a bit redundant and `uint16_t` parameter anyway will be promoted to `int` during the function call. Let me experiment a bit with variable parameters list a bit and I will come back with a wider answer. I need to renew things in memory by running some test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org