You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/04 07:27:08 UTC

[GitHub] [spark] martin-g commented on a diff in pull request #36443: [POC][WIP][SPARK-39088][CORE] Add a "live" driver link to the UI for history server when serving in-progress applications.

martin-g commented on code in PR #36443:
URL: https://github.com/apache/spark/pull/36443#discussion_r864523944


##########
core/src/main/scala/org/apache/spark/status/AppStatusStore.scala:
##########
@@ -763,6 +767,8 @@ private[spark] class AppStatusStore(
         AppStatusUtils.gettingResultTime(taskDataOld))
     }.toSeq
   }
+
+  private[spark] def isHistory(): Boolean = true

Review Comment:
   ```suggestion
     private[spark] def isHistory(): Boolean = false
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org