[GitHub] [spark] wangyum commented on a diff in pull request #35498: [SPARK-34777][UI] StagePage input/output size records not show when r…

[GitBox <gi...@apache.org>]

wangyum commented on code in PR #35498:
URL: https://github.com/apache/spark/pull/35498#discussion_r957956526


##########
core/src/main/resources/org/apache/spark/ui/static/stagepage.js:
##########
@@ -404,8 +404,8 @@ $(document).ready(function () {
   
         var responseBody = response;
         var dataToShow = {};
-        dataToShow.showInputData = responseBody.inputBytes > 0;
-        dataToShow.showOutputData = responseBody.outputBytes > 0;
+        dataToShow.showInputData = responseBody.inputBytes > 0 || responseBody.inputRecords > 0 ;
+        dataToShow.showOutputData = responseBody.outputBytes > 0 || responseBody.outputRecords > 0;

Review Comment:
   Adding `responseBody.inputRecords > 0` seems correct. But why do we need to add `responseBody.outputRecords > 0`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org