You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Markus Wichitill <ma...@gmx.de> on 2004/08/13 03:35:06 UTC

[mp2] t/api/custom_response.t needs binmode

t/api/custom_response.t needs binmode to succeed on Win32:

Index: t/api/custom_response.t
===================================================================
RCS file: /home/cvspublic/modperl-2.0/t/api/custom_response.t,v
retrieving revision 1.2
diff -u -r1.2 custom_response.t
--- t/api/custom_response.t	3 Aug 2004 16:22:44 -0000	1.2
+++ t/api/custom_response.t	13 Aug 2004 01:21:26 -0000
@@ -20,7 +20,7 @@
      qw(api custom_response.txt);

  open my $fh, $file or die "Can't open $file: $!";
-my $data = do { local $/; <$fh> };
+my $data = do { binmode $fh; local $/; <$fh> };
  close $fh;

  plan tests => 4, need_lwp;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] t/api/custom_response.t needs binmode

Posted by Stas Bekman <st...@stason.org>.
Markus Wichitill wrote:
> t/api/custom_response.t needs binmode to succeed on Win32:
> 
> Index: t/api/custom_response.t
> ===================================================================
> RCS file: /home/cvspublic/modperl-2.0/t/api/custom_response.t,v
> retrieving revision 1.2
> diff -u -r1.2 custom_response.t
> --- t/api/custom_response.t    3 Aug 2004 16:22:44 -0000    1.2
> +++ t/api/custom_response.t    13 Aug 2004 01:21:26 -0000
> @@ -20,7 +20,7 @@
>      qw(api custom_response.txt);
> 
>  open my $fh, $file or die "Can't open $file: $!";
> -my $data = do { local $/; <$fh> };
> +my $data = do { binmode $fh; local $/; <$fh> };
>  close $fh;
> 
>  plan tests => 4, need_lwp;

Thanks Markus, committed.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org