You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by yo...@apache.org on 2012/07/24 14:46:42 UTC
svn commit: r1365014 - in /lucene/dev/trunk/solr/core/src:
java/org/apache/solr/update/ java/org/apache/solr/update/processor/
test/org/apache/solr/cloud/
Author: yonik
Date: Tue Jul 24 12:46:41 2012
New Revision: 1365014
URL: http://svn.apache.org/viewvc?rev=1365014&view=rev
Log:
SOLR-3559: distributed DBQ did not respect the FROMLEADER param
Modified:
lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateCommand.java
lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java
lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateCommand.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateCommand.java?rev=1365014&r1=1365013&r2=1365014&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateCommand.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateCommand.java Tue Jul 24 12:46:41 2012
@@ -44,7 +44,7 @@ public abstract class UpdateCommand impl
@Override
public String toString() {
- return name() + "{flags="+flags+",version="+version;
+ return name() + "{flags="+flags+",_version_="+version;
}
public long getVersion() {
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java?rev=1365014&r1=1365013&r2=1365014&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java Tue Jul 24 12:46:41 2012
@@ -748,7 +748,10 @@ public class DistributedUpdateProcessor
if (zkEnabled && DistribPhase.TOLEADER == phase) {
// This core should be a leader
+ isLeader = true;
replicas = setupRequest();
+ } else if (DistribPhase.FROMLEADER == phase) {
+ isLeader = false;
}
if (vinfo == null) {
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java?rev=1365014&r1=1365013&r2=1365014&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java Tue Jul 24 12:46:41 2012
@@ -66,7 +66,7 @@ import org.slf4j.LoggerFactory;
*/
@Slow
public class FullSolrCloudTest extends AbstractDistributedZkTestCase {
- private static Logger log = LoggerFactory.getLogger(FullSolrCloudTest.class);
+ static Logger log = LoggerFactory.getLogger(FullSolrCloudTest.class);
@BeforeClass
public static void beforeFullSolrCloudTest() {
@@ -508,11 +508,15 @@ public class FullSolrCloudTest extends A
protected void del(String q) throws Exception {
controlClient.deleteByQuery(q);
+ cloudClient.deleteByQuery(q);
+
+ /***
for (SolrServer client : clients) {
UpdateRequest ureq = new UpdateRequest();
// ureq.setParam("update.chain", DISTRIB_UPDATE_CHAIN);
ureq.deleteByQuery(q).process(client);
}
+ ***/
}// serial commit...
/*
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java?rev=1365014&r1=1365013&r2=1365014&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java Tue Jul 24 12:46:41 2012
@@ -89,9 +89,7 @@ public class SyncSliceTest extends FullS
waitForThingsToLevelOut();
- // something wrong with this?
- //del("*:*");
-
+ del("*:*");
List<String> skipServers = new ArrayList<String>();
indexDoc(skipServers, id, 0, i1, 50, tlong, 50, t1,