You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by sebb <se...@gmail.com> on 2020/01/13 09:24:35 UTC
Re: [whimsy] branch master updated: avoid infinite recursion
On Mon, 13 Jan 2020 at 02:11, <ru...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> rubys pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new f6913ac avoid infinite recursion
> f6913ac is described below
>
> commit f6913ac5578f3f09ccd4c955cbecc6261424611b
> Author: Sam Ruby <ru...@intertwingly.net>
> AuthorDate: Sun Jan 12 21:11:11 2020 -0500
>
> avoid infinite recursion
>
I don't understand why those references to members/owners should need to be
treated specially and not others that appear very similar?
I think this needs to be documented in the code.
---
> lib/whimsy/asf/ldap.rb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
> index 8eba13a..8b8d7f1 100644
> --- a/lib/whimsy/asf/ldap.rb
> +++ b/lib/whimsy/asf/ldap.rb
> @@ -1183,7 +1183,7 @@ module ASF
> ASF.search_one(base, "cn=#{name}", 'owner').flatten
> end
>
> - owners.map {|uid| Person.find uid[/uid=(.*?),/,1]}
> + @owners.map {|uid| Person.find uid[/uid=(.*?),/,1]}
> end
>
> # list of owner ids in the project
> @@ -1389,7 +1389,7 @@ module ASF
> ASF.search_one(base, "cn=#{name}", 'member').flatten
> end
>
> - members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
> + @members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
> end
>
> # list of memberids for this service in LDAP
>
>
Re: [whimsy] branch master updated: avoid infinite recursion
Posted by sebb <se...@gmail.com>.
However had to revert it all as the code can now fail with Invalid
Reference.
I think the @members etc caching needs rethinking.
On Mon, 13 Jan 2020 at 10:03, sebb <se...@gmail.com> wrote:
> On Mon, 13 Jan 2020 at 09:24, sebb <se...@gmail.com> wrote:
>
>> On Mon, 13 Jan 2020 at 02:11, <ru...@apache.org> wrote:
>>
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> rubys pushed a commit to branch master
>>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/master by this push:
>>> new f6913ac avoid infinite recursion
>>> f6913ac is described below
>>>
>>> commit f6913ac5578f3f09ccd4c955cbecc6261424611b
>>> Author: Sam Ruby <ru...@intertwingly.net>
>>> AuthorDate: Sun Jan 12 21:11:11 2020 -0500
>>>
>>> avoid infinite recursion
>>>
>>
>> I don't understand why those references to members/owners should need to
>> be treated specially and not others that appear very similar?
>>
>
> There was another that needed fixing.
>
>
>>
>> I think this needs to be documented in the code.
>>
>>
> Done.
>
>
>> ---
>>> lib/whimsy/asf/ldap.rb | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
>>> index 8eba13a..8b8d7f1 100644
>>> --- a/lib/whimsy/asf/ldap.rb
>>> +++ b/lib/whimsy/asf/ldap.rb
>>> @@ -1183,7 +1183,7 @@ module ASF
>>> ASF.search_one(base, "cn=#{name}", 'owner').flatten
>>> end
>>>
>>> - owners.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>>> + @owners.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>>> end
>>>
>>> # list of owner ids in the project
>>> @@ -1389,7 +1389,7 @@ module ASF
>>> ASF.search_one(base, "cn=#{name}", 'member').flatten
>>> end
>>>
>>> - members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>>> + @members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>>> end
>>>
>>> # list of memberids for this service in LDAP
>>>
>>>
Re: [whimsy] branch master updated: avoid infinite recursion
Posted by sebb <se...@gmail.com>.
On Mon, 13 Jan 2020 at 09:24, sebb <se...@gmail.com> wrote:
> On Mon, 13 Jan 2020 at 02:11, <ru...@apache.org> wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> rubys pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>>
>>
>> The following commit(s) were added to refs/heads/master by this push:
>> new f6913ac avoid infinite recursion
>> f6913ac is described below
>>
>> commit f6913ac5578f3f09ccd4c955cbecc6261424611b
>> Author: Sam Ruby <ru...@intertwingly.net>
>> AuthorDate: Sun Jan 12 21:11:11 2020 -0500
>>
>> avoid infinite recursion
>>
>
> I don't understand why those references to members/owners should need to
> be treated specially and not others that appear very similar?
>
There was another that needed fixing.
>
> I think this needs to be documented in the code.
>
>
Done.
> ---
>> lib/whimsy/asf/ldap.rb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
>> index 8eba13a..8b8d7f1 100644
>> --- a/lib/whimsy/asf/ldap.rb
>> +++ b/lib/whimsy/asf/ldap.rb
>> @@ -1183,7 +1183,7 @@ module ASF
>> ASF.search_one(base, "cn=#{name}", 'owner').flatten
>> end
>>
>> - owners.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>> + @owners.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>> end
>>
>> # list of owner ids in the project
>> @@ -1389,7 +1389,7 @@ module ASF
>> ASF.search_one(base, "cn=#{name}", 'member').flatten
>> end
>>
>> - members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>> + @members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
>> end
>>
>> # list of memberids for this service in LDAP
>>
>>