You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2022/07/13 17:46:30 UTC
[kudu-CR] KUDU-2671 Fix Typo in master-test.cc
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18726
Change subject: KUDU-2671 Fix Typo in master-test.cc
......................................................................
KUDU-2671 Fix Typo in master-test.cc
This change fixes a type introduced in master-test.cc previously.
This is a follow up to 250eb90bc0e1f4f472f44de8a23ce213595d5ee7
Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
---
M src/kudu/master/master-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/18726/1
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR] KUDU-2671 Fix typo in master-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18726 )
Change subject: KUDU-2671 Fix typo in master-test.cc
......................................................................
KUDU-2671 Fix typo in master-test.cc
This change fixes a type introduced in master-test.cc previously.
This is a follow up to 250eb90bc0e1f4f472f44de8a23ce213595d5ee7.
Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Reviewed-on: http://gerrit.cloudera.org:8080/18726
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/master-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
Mahesh Reddy: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 Fix Typo in master-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18726 )
Change subject: KUDU-2671 Fix Typo in master-test.cc
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18726/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18726/1//COMMIT_MSG@9
PS1, Line 9: type
typo
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 17:50:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 Fix typo in master-test.cc
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18726 )
Change subject: KUDU-2671 Fix typo in master-test.cc
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18726/1//COMMIT_MSG
Commit Message:
PS1:
> Could you re-base this patch on top of the HEAD of the upstream master bran
Done
http://gerrit.cloudera.org:8080/#/c/18726/1//COMMIT_MSG@9
PS1, Line 9: type
> typo
Done
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 18:46:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 Fix typo in master-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18726 )
Change subject: KUDU-2671 Fix typo in master-test.cc
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 18:46:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 Fix typo in master-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 Fix typo in master-test.cc
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 Fix typo in master-test.cc
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18726
to look at the new patch set (#2).
Change subject: KUDU-2671 Fix typo in master-test.cc
......................................................................
KUDU-2671 Fix typo in master-test.cc
This change fixes a type introduced in master-test.cc previously.
This is a follow up to 250eb90bc0e1f4f472f44de8a23ce213595d5ee7.
Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
---
M src/kudu/master/master-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/18726/2
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 Fix typo in master-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18726 )
Change subject: KUDU-2671 Fix typo in master-test.cc
......................................................................
Patch Set 2: Verified+1
unrelated test failure in TestPstackWatcher.TestDumpStacks
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 19:42:51 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 Fix Typo in master-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18726 )
Change subject: KUDU-2671 Fix Typo in master-test.cc
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18726/1//COMMIT_MSG
Commit Message:
PS1:
Could you re-base this patch on top of the HEAD of the upstream master branch in the kudu git repo? Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 17:53:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 Fix typo in master-test.cc
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18726 )
Change subject: KUDU-2671 Fix typo in master-test.cc
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6731128b063355c71b7de1d46d0f9d1335c141
Gerrit-Change-Number: 18726
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 18:49:43 +0000
Gerrit-HasComments: No