You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/02/06 10:49:28 UTC

[GitHub] [dubbo] jessin20161124 opened a new pull request #9653: support config ReferenceBean by the way of static @Bean method or @Bean method in @Component java config

jessin20161124 opened a new pull request #9653:
URL: https://github.com/apache/dubbo/pull/9653


   
   ## What is the purpose of the change
   There exists bug when config ReferenceBean by the way of static @Bean method or @Bean method in @Component java config. You can run the following two tests in this pr:
   - dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/boot/conditional5/JavaConfigReferenceBeanConditionalTest5.java
   - dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/boot/conditional7/JavaConfigReferenceBeanConditionalTest7.java
   
   
   ## Brief changelog
     The original author use beanFactory#getType() as the ReferenceConfig's  interface name, which may cause early instantiation but get null objectType in the case of static @Bean method or @Bean method in @Component java config bean to build ReferenceBean.
   Here I modify the above logic and just get the return generic type as interface name from the @Bean method at the registry time. And all the config ReferenceBean case with @Bean method is supported, the original usage is also compatible. When the ReferenceBean is configured in the same method name, I just get common ancestor of return generic type here like the spring internals do.
   
   
   ## Verifying this change
   - dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/boot/conditional5/JavaConfigReferenceBeanConditionalTest5.java
   - dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/boot/conditional5/JavaConfigReferenceBeanConditionalTest6.java
   - dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/boot/conditional7/JavaConfigReferenceBeanConditionalTest7.java
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] jessin20161124 commented on pull request #9653: support config ReferenceBean by the way of static @Bean method or @Bean method in @Component java config

Posted by GitBox <gi...@apache.org>.
jessin20161124 commented on pull request #9653:
URL: https://github.com/apache/dubbo/pull/9653#issuecomment-1043825103


   Any feedback regarding this pr? @AlbumenJ @chickenlj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] AlbumenJ commented on a change in pull request #9653: support config ReferenceBean by the way of static @Bean method or @Bean method in @Component java config

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #9653:
URL: https://github.com/apache/dubbo/pull/9653#discussion_r814578551



##########
File path: dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/boot/conditional7/consumer/AnnotationBeanConfiguration.java
##########
@@ -0,0 +1,22 @@
+package org.apache.dubbo.config.spring.boot.conditional7.consumer;

Review comment:
       Please add ASF license header.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] jessin20161124 commented on a change in pull request #9653: support config ReferenceBean by the way of static @Bean method or @Bean method in @Component java config

Posted by GitBox <gi...@apache.org>.
jessin20161124 commented on a change in pull request #9653:
URL: https://github.com/apache/dubbo/pull/9653#discussion_r814597050



##########
File path: dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/boot/conditional7/consumer/AnnotationBeanConfiguration.java
##########
@@ -0,0 +1,22 @@
+package org.apache.dubbo.config.spring.boot.conditional7.consumer;

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] jessin20161124 commented on pull request #9653: support config ReferenceBean by the way of static @Bean method or @Bean method in @Component java config

Posted by GitBox <gi...@apache.org>.
jessin20161124 commented on pull request #9653:
URL: https://github.com/apache/dubbo/pull/9653#issuecomment-1068793941


   Any feedback about this pr?  @AlbumenJ @chickenlj 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org