You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/07/30 14:12:33 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #513: protect 1.0.x branch
pjfanning opened a new pull request, #513:
URL: https://github.com/apache/incubator-pekko/pull/513
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #513: protect 1.0.x branch
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #513:
URL: https://github.com/apache/incubator-pekko/pull/513#issuecomment-1657186738
> > should we genericise the job using one of the answers in this (maybe the 280 vote one)?
> > https://stackoverflow.com/questions/58033366/how-to-get-the-current-branch-within-github-actions
>
> Sure go ahead, lets try it before merging this PR
I thought about it again and I suspect that we could end up getting PRs to validate against the PR branch as opposed to the target branch. Possibly just easier to hardcode the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #513: protect 1.0.x branch
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #513:
URL: https://github.com/apache/incubator-pekko/pull/513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #513: protect 1.0.x branch
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #513:
URL: https://github.com/apache/incubator-pekko/pull/513#issuecomment-1657186135
> Note that before you protect 1.0.x branch you need to add a commit to update https://github.com/apache/incubator-pekko/blob/main/.github/workflows/format.yml#L24 to arguments: `--list --mode diff-ref=origin/1.0.x` (if you want I can do this).
should we genericise the job using one of the answers in this (maybe the 280 vote one)?
https://stackoverflow.com/questions/58033366/how-to-get-the-current-branch-within-github-actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #513: protect 1.0.x branch
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #513:
URL: https://github.com/apache/incubator-pekko/pull/513#issuecomment-1657186378
> should we genericise the job using one of the answers in this (maybe the 280 vote one)?
>
> https://stackoverflow.com/questions/58033366/how-to-get-the-current-branch-within-github-actions
Sure go ahead, lets try it before merging this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #513: protect 1.0.x branch
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #513:
URL: https://github.com/apache/incubator-pekko/pull/513#issuecomment-1657184887
Note that before you protect 1.0.x branch you need to add a commit to update https://github.com/apache/incubator-pekko/blob/main/.github/workflows/format.yml#L24 to arguments: '--list --mode diff-ref=origin/1.0.x' (if you want I can do this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org