You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sureshsubbiah <gi...@git.apache.org> on 2015/09/17 02:30:51 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1456] Merge statement...
GitHub user sureshsubbiah opened a pull request:
https://github.com/apache/incubator-trafodion/pull/83
[TRAFODION-1456] Merge statement returns error 3241 when there is unique index in the table [TRAFODION-1493] Logs TMDUF does not scan udr logs Also enabled merge with views and merge with RI constraint.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshsubbiah/incubator-trafodion jira_bugs2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 4b2cfc8ac5160a955da5a663df044ab8c48ec44e
Author: Suresh Subbiah <su...@apache.org>
Date: 2015-09-16T23:27:46Z
[TRAFODION-1456] Merge statement returns error 3241 when there is unique index in the table
[TRAFODION-1493] Logs TMDUF does not scan udr logs
Also enabled merge with views and merge with RI constraint.
commit 7de5f8641389a051b996a7d00bb9d06bd580c87a
Author: Suresh Subbiah <su...@apache.org>
Date: 2015-09-17T00:24:04Z
Rebase changes.
Removed DETAILED_STATISTICS cqd setting for ustat.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1456] Merge statement...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/83#discussion_r39711664
--- Diff: core/sql/executor/ExHbaseIUD.cpp ---
@@ -472,7 +472,15 @@ ExWorkProcRetcode ExHbaseAccessInsertSQTcb::work()
{
rc = applyPred(scanExpr());
if (rc == 1) // expr is true or no expr
- step_ = CREATE_MUTATIONS;
+ {
+ rc = evalInsDelPreCondExpr();
--- End diff --
Should we consider move this expression evaluation to SETUP_INSERT step since it evaluates from queue entry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1456] Merge statement...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1456] Merge statement...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/83#discussion_r39713217
--- Diff: core/sql/executor/ExHbaseIUD.cpp ---
@@ -472,7 +472,15 @@ ExWorkProcRetcode ExHbaseAccessInsertSQTcb::work()
{
rc = applyPred(scanExpr());
if (rc == 1) // expr is true or no expr
- step_ = CREATE_MUTATIONS;
+ {
+ rc = evalInsDelPreCondExpr();
--- End diff --
I thought of the preConditionExpr as something similar to the scanExpr. Agree that it is on upqueue though. Do not see any benefit from changing except if we are thinking that some steps are avoided? I can try it out, but would rather do that in a separate checkin if we want to go that route.
About VsbbUpsert, right now the preCondition expression is evaluated only for unique index for which we need CheckAndPut. I am assuming this is always in the SQInsertTcb. Merge on native HBase tables is also not supported yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---