You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/04/17 00:27:15 UTC
[GitHub] [orc] noirello opened a new pull request, #1088: ORC-1151: [C++] Incorrect statistics for Timestamp column with non UTC writer time zones
noirello opened a new pull request, #1088:
URL: https://github.com/apache/orc/pull/1088
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
Fix converting non UTC timestamps for statistics.
### Why are the changes needed?
Currently, the statistics for timestamp columns are incorrect, when the writer's time zone is not UTC.
### How was this patch tested?
Ran the existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] noirello commented on a diff in pull request #1088: ORC-1151: [C++] Incorrect statistics for Timestamp column with non UTC writer time zones
Posted by GitBox <gi...@apache.org>.
noirello commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851760919
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
Please, double check the timestamps in the test cases. Time zones always can be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] noirello commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
noirello commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r852041432
##########
c++/test/TestTimestampStatistics.cc:
##########
@@ -57,4 +62,97 @@ namespace orc {
EXPECT_EQ("Data type: Timestamp\nValues: 12\nHas null: no\nMinimum: 1995-01-01 00:00:00.688\nLowerBound: 1995-01-01 00:00:00.688\nMaximum: 2037-01-01 00:00:00.0\nUpperBound: 2037-01-01 00:00:00.1\n", stripeColStats->toString());
}
+ TEST(TestTimestampStatistics, testTimezoneUTC) {
+ MemoryOutputStream memStream(DEFAULT_MEM_STREAM_SIZE);
+ MemoryPool *pool = getDefaultPool();
+ std::unique_ptr<Type> type(Type::buildTypeFromString("struct<col:timestamp>"));
+ WriterOptions wOptions;
+ wOptions.setMemoryPool(pool);
+ std::unique_ptr<Writer> writer = createWriter(*type, &memStream, wOptions);
+ std::unique_ptr<ColumnVectorBatch> batch = writer->createRowBatch(1024);
+ StructVectorBatch *root = dynamic_cast<StructVectorBatch *>(batch.get());
+ TimestampVectorBatch *col = dynamic_cast<orc::TimestampVectorBatch *>(root->fields[0]);
+
+ int64_t expectedMinMillis = 1650133963321; // 2022-04-16T18:32:43.321+00:00
+ int64_t expectedMaxMillis = 1650133964321; // 2022-04-16T18:32:44.321+00:00
+
+ col->data[0] = expectedMinMillis / 1000;
+ col->nanoseconds[0] = expectedMinMillis % 1000 * 1000000;
+ col->data[1] = expectedMaxMillis / 1000;
+ col->nanoseconds[1] = expectedMaxMillis % 1000 * 1000000;
+ col->numElements = 2;
+ root->numElements = 2;
+
+ writer->add(*batch);
+ writer->close();
+
+ std::unique_ptr<InputStream> inStream(new MemoryInputStream(
+ memStream.getData(), memStream.getLength()));
+ ReaderOptions rOptions;
+ rOptions.setMemoryPool(*pool);
+ std::unique_ptr<Reader> reader = createReader(std::move(inStream), rOptions);
+
+ std::unique_ptr<StripeStatistics> stripeStats = reader->getStripeStatistics(0);
+ const TimestampColumnStatistics* stripeColStats =
+ reinterpret_cast<const TimestampColumnStatistics*>(stripeStats->getColumnStatistics(1));
+
+
Review Comment:
It's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851842056
##########
c++/test/TestTimestampStatistics.cc:
##########
@@ -57,4 +62,97 @@ namespace orc {
EXPECT_EQ("Data type: Timestamp\nValues: 12\nHas null: no\nMinimum: 1995-01-01 00:00:00.688\nLowerBound: 1995-01-01 00:00:00.688\nMaximum: 2037-01-01 00:00:00.0\nUpperBound: 2037-01-01 00:00:00.1\n", stripeColStats->toString());
}
+ TEST(TestTimestampStatistics, testTimezoneUTC) {
+ MemoryOutputStream memStream(DEFAULT_MEM_STREAM_SIZE);
+ MemoryPool *pool = getDefaultPool();
+ std::unique_ptr<Type> type(Type::buildTypeFromString("struct<col:timestamp>"));
+ WriterOptions wOptions;
+ wOptions.setMemoryPool(pool);
+ std::unique_ptr<Writer> writer = createWriter(*type, &memStream, wOptions);
+ std::unique_ptr<ColumnVectorBatch> batch = writer->createRowBatch(1024);
+ StructVectorBatch *root = dynamic_cast<StructVectorBatch *>(batch.get());
+ TimestampVectorBatch *col = dynamic_cast<orc::TimestampVectorBatch *>(root->fields[0]);
+
+ int64_t expectedMinMillis = 1650133963321; // 2022-04-16T18:32:43.321+00:00
+ int64_t expectedMaxMillis = 1650133964321; // 2022-04-16T18:32:44.321+00:00
+
+ col->data[0] = expectedMinMillis / 1000;
+ col->nanoseconds[0] = expectedMinMillis % 1000 * 1000000;
+ col->data[1] = expectedMaxMillis / 1000;
+ col->nanoseconds[1] = expectedMaxMillis % 1000 * 1000000;
+ col->numElements = 2;
+ root->numElements = 2;
+
+ writer->add(*batch);
+ writer->close();
+
+ std::unique_ptr<InputStream> inStream(new MemoryInputStream(
+ memStream.getData(), memStream.getLength()));
+ ReaderOptions rOptions;
+ rOptions.setMemoryPool(*pool);
+ std::unique_ptr<Reader> reader = createReader(std::move(inStream), rOptions);
+
+ std::unique_ptr<StripeStatistics> stripeStats = reader->getStripeStatistics(0);
+ const TimestampColumnStatistics* stripeColStats =
+ reinterpret_cast<const TimestampColumnStatistics*>(stripeStats->getColumnStatistics(1));
+
+
Review Comment:
Shall we remove an empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] noirello commented on a diff in pull request #1088: ORC-1151: [C++] Incorrect statistics for Timestamp column with non UTC writer time zones
Posted by GitBox <gi...@apache.org>.
noirello commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851760641
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
Sure, added a UTC and a non UTC test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] stiga-huang merged pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
stiga-huang merged PR #1088:
URL: https://github.com/apache/orc/pull/1088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] noirello commented on pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
noirello commented on PR #1088:
URL: https://github.com/apache/orc/pull/1088#issuecomment-1102159784
> +1, LGTM. Do we need this at ORC 1.7.5?
Yes, I think this should be included in the 1.7 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1088:
URL: https://github.com/apache/orc/pull/1088#issuecomment-1102171023
+1 for backporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Incorrect statistics for Timestamp column with non UTC writer time zones
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851687569
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
Thank you, @noirello . Could you make a test case for this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851842026
##########
c++/test/TestTimestampStatistics.cc:
##########
@@ -57,4 +62,97 @@ namespace orc {
EXPECT_EQ("Data type: Timestamp\nValues: 12\nHas null: no\nMinimum: 1995-01-01 00:00:00.688\nLowerBound: 1995-01-01 00:00:00.688\nMaximum: 2037-01-01 00:00:00.0\nUpperBound: 2037-01-01 00:00:00.1\n", stripeColStats->toString());
}
+ TEST(TestTimestampStatistics, testTimezoneUTC) {
+ MemoryOutputStream memStream(DEFAULT_MEM_STREAM_SIZE);
+ MemoryPool *pool = getDefaultPool();
+ std::unique_ptr<Type> type(Type::buildTypeFromString("struct<col:timestamp>"));
+ WriterOptions wOptions;
+ wOptions.setMemoryPool(pool);
+ std::unique_ptr<Writer> writer = createWriter(*type, &memStream, wOptions);
+ std::unique_ptr<ColumnVectorBatch> batch = writer->createRowBatch(1024);
+ StructVectorBatch *root = dynamic_cast<StructVectorBatch *>(batch.get());
+ TimestampVectorBatch *col = dynamic_cast<orc::TimestampVectorBatch *>(root->fields[0]);
+
+ int64_t expectedMinMillis = 1650133963321; // 2022-04-16T18:32:43.321+00:00
+ int64_t expectedMaxMillis = 1650133964321; // 2022-04-16T18:32:44.321+00:00
+
+ col->data[0] = expectedMinMillis / 1000;
+ col->nanoseconds[0] = expectedMinMillis % 1000 * 1000000;
+ col->data[1] = expectedMaxMillis / 1000;
+ col->nanoseconds[1] = expectedMaxMillis % 1000 * 1000000;
+ col->numElements = 2;
+ root->numElements = 2;
+
+ writer->add(*batch);
+ writer->close();
+
+ std::unique_ptr<InputStream> inStream(new MemoryInputStream(
+ memStream.getData(), memStream.getLength()));
+ ReaderOptions rOptions;
+ rOptions.setMemoryPool(*pool);
+ std::unique_ptr<Reader> reader = createReader(std::move(inStream), rOptions);
+
+ std::unique_ptr<StripeStatistics> stripeStats = reader->getStripeStatistics(0);
+ const TimestampColumnStatistics* stripeColStats =
+ reinterpret_cast<const TimestampColumnStatistics*>(stripeStats->getColumnStatistics(1));
+
+
+ EXPECT_TRUE(stripeColStats->hasLowerBound());
+ EXPECT_TRUE(stripeColStats->hasUpperBound());
+ EXPECT_TRUE(stripeColStats->hasMinimum());
+ EXPECT_TRUE(stripeColStats->hasMaximum());
+ EXPECT_EQ(stripeColStats->getMinimum(), expectedMinMillis);
+ EXPECT_EQ(stripeColStats->getMaximum(), expectedMaxMillis);
+ EXPECT_EQ(stripeColStats->getLowerBound(), expectedMinMillis);
+ EXPECT_EQ(stripeColStats->getUpperBound(), expectedMaxMillis + 1);
+ }
+
+ TEST(TestTimestampStatistics, testTimezoneNonUTC) {
Review Comment:
Thank you for adding this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851862133
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
Got it. +1 for @wgtmac 's final decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851841698
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
Yes, it's a little counter-intuitive because we only convert `secs[i]` only. So, `Timezone.convertToUTC` doesn't care nanos part and we should not put it.
https://github.com/apache/orc/blob/f4c7cc14b31876e3dd4934b4bfc40c05d4b8ebca/c%2B%2B/src/Timezone.cc#L604-L606
If then, can we fix it in `Timezone.convertToUTC` instead? Is there a side-effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851841698
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
It's a little counter-intuitive because we only convert `secs[i]` only. Could you add some comment here about why we don't need to convert `nanos[i]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851849032
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
cc @wgtmac , @stiga-huang too because this is a correctness issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851841698
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
Yes, it's a little counter-intuitive because we only convert `secs[i]` only. So, `Timezone.convertToUTC` doesn't care `nanos` part properly and we should not put it here?
https://github.com/apache/orc/blob/f4c7cc14b31876e3dd4934b4bfc40c05d4b8ebca/c%2B%2B/src/Timezone.cc#L604-L606
If then, can we fix it in `Timezone.convertToUTC` instead? Is there a side-effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on a diff in pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
wgtmac commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851858410
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
If we have set nanosecond in the test case _**WriterTest.writeTimestampWithTimezone**_, this issue may be fixed earlier.
##########
c++/src/ColumnWriter.cc:
##########
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 + nanos[i] / 1000000;
if (!isUTC) {
- millsUTC = timezone.convertToUTC(millsUTC);
+ millsUTC = timezone.convertToUTC(secs[i]) * 1000 + nanos[i] / 1000000;
Review Comment:
> Yes, it's a little counter-intuitive because we only convert `secs[i]` only. So, `Timezone.convertToUTC` doesn't care `nanos` part properly and we should not put it here?
>
> https://github.com/apache/orc/blob/f4c7cc14b31876e3dd4934b4bfc40c05d4b8ebca/c%2B%2B/src/Timezone.cc#L604-L606
>
> If then, can we fix it in `Timezone.convertToUTC` instead? Is there a side-effect?
I think the current fix is good enough. As time_t uses second internally, we'd better keep the contract of Timezone.convertToUTC. We may add some comment above the fix to help understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1088: ORC-1151: [C++] Fix `ColumnWriter` for non-UTC Timestamp columns
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1088:
URL: https://github.com/apache/orc/pull/1088#issuecomment-1105936423
Hi All. I backported this to branch-1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org