[jira] [Commented] (FLINK-3729) Several SQL tests fail on Windows OS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374889#comment-15374889 ] 

ASF GitHub Bot commented on FLINK-3729:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2238

    [FLINK-3729] Fix Several SQL tests on Windows OS 

    - fixed ExplainTest by replacing all occurrences of `\r\n` with `\n` before comparing the output
    - replaced usages of `\n` in BatchTableEnvironment#explain() with System.lineSeparator
    - fixed TableSinkITCase by generating the qualidifed path using `File#toUri()` and `URI#toString()`
    - removed a lot of unused imports in TableSinkITCase

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 3729_sql_tests_windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2238
    
----
commit 0694fde595289b4ae145544fb39598fee63e8bf5
Author: zentol <ch...@apache.org>
Date:   2016-07-13T11:51:05Z

    [FLINK-3729][table] Fix ExplainTest on Windows OS

commit d79866a78b30d6794c6c96431ac53d6a5119890d
Author: zentol <ch...@apache.org>
Date:   2016-07-13T11:51:34Z

    [FLINK-3729][table] Fix TableSinkITCase on Windows OS

commit 31c121c25cae70262c0187e43b41a144a326ab33
Author: zentol <ch...@apache.org>
Date:   2016-07-13T11:51:53Z

    [hotfix][table] Remove unused imports in TableSinkITCase

----


> Several SQL tests fail on Windows OS
> ------------------------------------
>
>                 Key: FLINK-3729
>                 URL: https://issues.apache.org/jira/browse/FLINK-3729
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.0.1
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> The Table API SqlExplain(Test/ITCase) fail categorically on Windows due to different line-endings. These tests generate an string representation of an abstract syntax tree; problem is there is a difference in line-endings.
> The expected ones contain LF, the actual one CRLF.
> The tests should be either changed to either
> * include CRLF line-endings in the expected string when run on windows
> * always use LF line-endings regardless of OS
> * use a compare method that is aware of this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)