You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/28 19:35:47 UTC
[GitHub] [accumulo] jmark99 opened a new pull request #2045: Move ignoreEmptyDir opt to ImportOptions interface
jmark99 opened a new pull request #2045:
URL: https://github.com/apache/accumulo/pull/2045
Update the importdirectory ignoreEmptyDir option to use the bulk import fluent API. The ignoreEmptyDir option is moved into the ImportOptions interface and can be set during the call to the load method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #2045: Move ignoreEmptyDir opt to ImportOptions interface
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2045:
URL: https://github.com/apache/accumulo/pull/2045#discussion_r623036563
##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -716,6 +716,11 @@ void importDirectory(String tableName, String dir, String failureDir, boolean se
*/
ImportMappingOptions tableTime(boolean value);
+ /**
+ * Ignores empty bulk import source directory, rather than throwing an IllegalArgumentException.
+ */
+ ImportMappingOptions ignoreEmptyDir(boolean ignore);
Review comment:
Should include `@since 2.1.0` java doc tag since this will be new.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 merged pull request #2045: Move ignoreEmptyDir opt to ImportOptions interface
Posted by GitBox <gi...@apache.org>.
jmark99 merged pull request #2045:
URL: https://github.com/apache/accumulo/pull/2045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 commented on a change in pull request #2045: Move ignoreEmptyDir opt to ImportOptions interface
Posted by GitBox <gi...@apache.org>.
jmark99 commented on a change in pull request #2045:
URL: https://github.com/apache/accumulo/pull/2045#discussion_r623051675
##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -716,6 +716,11 @@ void importDirectory(String tableName, String dir, String failureDir, boolean se
*/
ImportMappingOptions tableTime(boolean value);
+ /**
+ * Ignores empty bulk import source directory, rather than throwing an IllegalArgumentException.
+ */
+ ImportMappingOptions ignoreEmptyDir(boolean ignore);
Review comment:
Tag was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org