You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/12/06 06:54:25 UTC
[kudu-CR] WIP integration test for snapshot scans
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5375
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
3 files changed, 135 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/1
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5375
to look at the new patch set (#8).
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
Update: It seems I was overly ambitious. Enabling
this by default will take some time to deflake so
actually not starting read threads by default.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
9 files changed, 189 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/8
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5375
to look at the new patch set (#6).
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
Update: It seems I was overly ambitious. Enabling
this by default will take some time to deflake so
actually not starting read threads by default.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
9 files changed, 184 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/6
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5375
to look at the new patch set (#3).
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
Update: It seems I was overly ambitious. Enabling
this by default will take some time to deflake so
actually not starting read threads by default.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
3 files changed, 148 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/3
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: WIP integration test for snapshot scans
......................................................................
Patch Set 8:
(2 comments)
need to look at this in some more detail tomorrow. definitely needs some updates on comments to explain what the scan workload is, etc, not entirely following, but admittedly jetlagged :)
http://gerrit.cloudera.org:8080/#/c/5375/8/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:
Line 721: last_write_ts_for_tests_ = rpc.resp().has_timestamp();
this doesn't seem right at all... don't you mean resp().timestamp()? and maybe a std::max?
http://gerrit.cloudera.org:8080/#/c/5375/8/src/kudu/integration-tests/test_workload.h
File src/kudu/integration-tests/test_workload.h:
Line 166: int64_t rows_inserted() const {
a little confused.. you changed the sense of this variable internally but this accessor isn't changed?
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5375
to look at the new patch set (#5).
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
Update: It seems I was overly ambitious. Enabling
this by default will take some time to deflake so
actually not starting read threads by default.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/client/batcher.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
4 files changed, 157 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/5
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5375
to look at the new patch set (#7).
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
Update: It seems I was overly ambitious. Enabling
this by default will take some time to deflake so
actually not starting read threads by default.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
9 files changed, 187 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/7
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5375
to look at the new patch set (#2).
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/integration-tests/ts_recovery-itest.cc
7 files changed, 149 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/2
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has abandoned this change.
Change subject: WIP integration test for snapshot scans
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP integration test for snapshot scans
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5375
to look at the new patch set (#4).
Change subject: WIP integration test for snapshot scans
......................................................................
WIP integration test for snapshot scans
This makes executions of TestWorkload do snapshot
scans, by default. Since this changes the default
it likely requires some tweaking to disable when
not appropriate or to play with timeouts.
Update: It seems I was overly ambitious. Enabling
this by default will take some time to deflake so
actually not starting read threads by default.
This will eventually be merged with the safe time
patch but for now it's handy to keep this separate.
Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
---
M src/kudu/client/batcher.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
4 files changed, 157 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5375/4
--
To view, visit http://gerrit.cloudera.org:8080/5375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fa7d3e6afa841e346cc14b80e133bf8d3dbe63
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>