You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "lancelly (via GitHub)" <gi...@apache.org> on 2023/12/20 11:17:23 UTC
[PR] [IOTDB-6272] Fix wrong RealNumber check for PartialPath [iotdb]
lancelly opened a new pull request, #11754:
URL: https://github.com/apache/iotdb/pull/11754
Issue:https://issues.apache.org/jira/browse/IOTDB-6272
"0e38" should be considered as a real number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6272] Fix wrong RealNumber check for PartialPath [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11754:
URL: https://github.com/apache/iotdb/pull/11754#issuecomment-1864329590
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11754) **Quality Gate failed**
Failed conditions
[0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11754&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11754)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6272] Fix wrong RealNumber check for PartialPath [iotdb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11754:
URL: https://github.com/apache/iotdb/pull/11754#issuecomment-1864375546
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`ef6dc0a`)](https://app.codecov.io/gh/apache/iotdb/commit/ef6dc0a8e149cfaee705bc7795ada75f8c92025c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.02% compared to head [(`75fd34a`)](https://app.codecov.io/gh/apache/iotdb/pull/11754?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.19%.
> Report is 15 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #11754 +/- ##
============================================
+ Coverage 49.02% 49.19% +0.16%
- Complexity 25011 25263 +252
============================================
Files 2835 2847 +12
Lines 177395 178111 +716
Branches 21252 21302 +50
============================================
+ Hits 86965 87613 +648
- Misses 90430 90498 +68
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11754?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6272] Fix wrong RealNumber check for PartialPath [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #11754:
URL: https://github.com/apache/iotdb/pull/11754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org