You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/12/31 01:18:54 UTC
[PR] [SPARK-54868][PYTHON][INFRA][FOLLOW-UP] Also enable `faulthandler` in classic tests [spark]
zhengruifeng opened a new pull request, #53651:
URL: https://github.com/apache/spark/pull/53651
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Also enable `faulthandler` in classic tests, by introducing a base class `PySparkBaseTestCase`
### Why are the changes needed?
`faulthandler` was only enabled in `ReusedConnectTestCase` for spark connect,
after this change `faulthandler` will be enabled in most classic tests (There are still some tests directly use `unittest.TestCase`, we can change them when they hit hanging issues)
### Does this PR introduce _any_ user-facing change?
no, test-only
### How was this patch tested?
ci and manually check with
```
PYSPARK_TEST_TIMEOUT=10 python/run-tests -k --python-executables python3 --testnames 'pyspark.tests.test_util'
```
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54868][PYTHON][INFRA][FOLLOW-UP] Also enable `faulthandler` in classic tests [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53651:
URL: https://github.com/apache/spark/pull/53651#issuecomment-3701030196
## JIRA Issue Information
=== Improvement SPARK-54868 ===
Summary: Fail hanging tests and log the tracebacks
Assignee: Ruifeng Zheng
Status: Resolved
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54868][PYTHON][INFRA][FOLLOW-UP] Also enable `faulthandler` in classic tests [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #53651: [SPARK-54868][PYTHON][INFRA][FOLLOW-UP] Also enable `faulthandler` in classic tests
URL: https://github.com/apache/spark/pull/53651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54868][PYTHON][INFRA][FOLLOW-UP] Also enable `faulthandler` in classic tests [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #53651:
URL: https://github.com/apache/spark/pull/53651#issuecomment-3701467195
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org