You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/30 15:54:04 UTC
[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #22548: Fix start up NPE when use ShardingSphereDriver with cluster mode.
zhaojinchao95 opened a new pull request, #22548:
URL: https://github.com/apache/shardingsphere/pull/22548
Fix datasource properties comparison not right when properties are map type.
Fix start up NPE when use ShardingSphereDriver with cluster mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22548: Fix datasource properties comparison not right when properties are map type.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22548:
URL: https://github.com/apache/shardingsphere/pull/22548#issuecomment-1332458022
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22548](https://codecov.io/gh/apache/shardingsphere/pull/22548?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36a23ab) into [master](https://codecov.io/gh/apache/shardingsphere/commit/07300fdd7856ac91548851cd739e8fc8dedfc153?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07300fd) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #22548 +/- ##
============================================
- Coverage 50.99% 50.94% -0.05%
- Complexity 2514 2520 +6
============================================
Files 4185 4189 +4
Lines 58232 58313 +81
Branches 9898 9921 +23
============================================
+ Hits 29695 29708 +13
- Misses 26011 26078 +67
- Partials 2526 2527 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/infra/datasource/props/DataSourceProperties.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Byb3BzL0RhdGFTb3VyY2VQcm9wZXJ0aWVzLmphdmE=) | `87.80% <0.00%> (-4.51%)` | :arrow_down: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...proxy/backend/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `60.00% <0.00%> (-12.10%)` | :arrow_down: |
| [...trics/prometheus/collector/BuildInfoCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL3Byb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvcHJvbWV0aGV1cy9jb2xsZWN0b3IvQnVpbGRJbmZvQ29sbGVjdG9yLmphdmE=) | `62.50% <0.00%> (-6.25%)` | :arrow_down: |
| [...eger/definition/JaegerPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL2phZWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvamFlZ2VyL2RlZmluaXRpb24vSmFlZ2VyUGx1Z2luRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `88.88% <0.00%> (-5.23%)` | :arrow_down: |
| [...pkin/definition/ZipkinPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3ppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvemlwa2luL2RlZmluaXRpb24vWmlwa2luUGx1Z2luRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `88.88% <0.00%> (-5.23%)` | :arrow_down: |
| [...definition/OpenTracingPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL29wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9kZWZpbml0aW9uL09wZW5UcmFjaW5nUGx1Z2luRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `88.88% <0.00%> (-5.23%)` | :arrow_down: |
| [...n/OpenTelemetryTracingPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL29wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL29wZW50ZWxlbWV0cnkvZGVmaW5pdGlvbi9PcGVuVGVsZW1ldHJ5VHJhY2luZ1BsdWdpbkRlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `88.88% <0.00%> (-5.23%)` | :arrow_down: |
| [.../definition/PrometheusPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL3Byb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvcHJvbWV0aGV1cy9kZWZpbml0aW9uL1Byb21ldGhldXNQbHVnaW5EZWZpbml0aW9uU2VydmljZS5qYXZh) | `47.61% <0.00%> (-2.39%)` | :arrow_down: |
| [...rometheus/service/PrometheusPluginBootService.java](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL3Byb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvcHJvbWV0aGV1cy9zZXJ2aWNlL1Byb21ldGhldXNQbHVnaW5Cb290U2VydmljZS5qYXZh) | `66.66% <0.00%> (-1.34%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/shardingsphere/pull/22548/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22548: Fix datasource properties comparison not right when properties are map type.
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22548:
URL: https://github.com/apache/shardingsphere/pull/22548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org