You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/11 12:38:44 UTC
[GitHub] [hbase] nkalmar opened a new pull request #1163: HBASE-23828 -
Remove unused hadoop.guava.version from pom.xml
nkalmar opened a new pull request #1163: HBASE-23828 - Remove unused hadoop.guava.version from pom.xml
URL: https://github.com/apache/hbase/pull/1163
<hadoop.guava.version>11.0.2</hadoop.guava.version> is not used anywhere. It was added in https://github.com/apache/hbase/commit/0e95a8a0ae24b0d19b391d49794d6716a8e86bcd , when hbase-backup was using it. When it got removed in hbase-backup, this was forgotten. Static analyzers is now flagging hbase as there is a CVE for guava older versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] nkalmar commented on issue #1163: HBASE-23828 - Remove
unused hadoop.guava.version from pom.xml
Posted by GitBox <gi...@apache.org>.
nkalmar commented on issue #1163: HBASE-23828 - Remove unused hadoop.guava.version from pom.xml
URL: https://github.com/apache/hbase/pull/1163#issuecomment-584630106
Yes, that's a big mis on my part, sorry, I'm looking into it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1163: HBASE-23828 - Remove
unused hadoop.guava.version from pom.xml
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1163: HBASE-23828 - Remove unused hadoop.guava.version from pom.xml
URL: https://github.com/apache/hbase/pull/1163#issuecomment-584625550
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 2s | master passed |
| +1 :green_heart: | compile | 3m 20s | master passed |
| +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 58s | master passed |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 8s | root in the patch failed. |
| -1 :x: | compile | 0m 7s | root in the patch failed. |
| -1 :x: | javac | 0m 7s | root in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| -1 :x: | shadedjars | 0m 5s | patch has 12 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 0m 5s | The patch causes 12 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 0m 11s | The patch causes 12 errors with Hadoop v2.9.2. |
| -1 :x: | javadoc | 0m 10s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 10s | root in the patch failed. |
| +0 :ok: | asflicense | 0m 11s | ASF License check generated no output? |
| | | 26m 50s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1163 |
| Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 9aacac1e2af9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1163/out/precommit/personality/provided.sh |
| git revision | master / 12f98bc50e |
| Default Java | 1.8.0_181 |
| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-compile-root.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-javac-2.9.2.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/testReport/ |
| Max. process+thread count | 86 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1163/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1163: HBASE-23828 - Remove
unused hadoop.guava.version from pom.xml
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on issue #1163: HBASE-23828 - Remove unused hadoop.guava.version from pom.xml
URL: https://github.com/apache/hbase/pull/1163#issuecomment-584626626
It seems that this property is still used in the `hadoop-2.0` profile of hbase-backup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] nkalmar edited a comment on issue #1163: HBASE-23828 -
Remove unused hadoop.guava.version from pom.xml
Posted by GitBox <gi...@apache.org>.
nkalmar edited a comment on issue #1163: HBASE-23828 - Remove unused hadoop.guava.version from pom.xml
URL: https://github.com/apache/hbase/pull/1163#issuecomment-584630106
Yes, that's a big miss on my part, sorry, I'm looking into it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] nkalmar closed pull request #1163: HBASE-23828 - Remove
unused hadoop.guava.version from pom.xml
Posted by GitBox <gi...@apache.org>.
nkalmar closed pull request #1163: HBASE-23828 - Remove unused hadoop.guava.version from pom.xml
URL: https://github.com/apache/hbase/pull/1163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services