[GitHub] sijie opened a new pull request #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky
URL: https://github.com/apache/bookkeeper/pull/1165
 
 
   
   Descriptions of the changes in this PR:
   
   *Problem*
   
   log segments are truncated in the background after TTL. the truncation is done asynchronously.
   so when we finish writing all the log records, the truncation might still not complete yet.
   
   *Solution*
   
   Improve the test case to wait until the last truncation attempt is completed before asserting the log segments
   
   
   Master Issue: #1164 
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services