[jira] [Commented] (SLING-4665) Provide a Helper class to compare topology views

["Timothee Maret (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515061#comment-14515061 ] 

Timothee Maret commented on SLING-4665:
---------------------------------------

[~egli] Generally, given two instances in the same TopologyView, can we assume that no two instances will have the same Sling id ?
If we can assume that (Sling id is unique across the whole topology), then we could build the helper using a comparison on the Sling id and dealing with sets of instances. Uniquely identifying instances would also allow to filter by properties (if they match or not).

In the other hand, if there could be two instances in the same topology with the same sling id, then the helper would need to be design in a way that it deal with collections of instances. with this version, and filtering by properties may be removed since we wouldn't know which instances to compare.

Which one of the two approach seems more correct given the Discovery API and impl ?

> Provide a Helper class to compare topology views
> ------------------------------------------------
>
>                 Key: SLING-4665
>                 URL: https://issues.apache.org/jira/browse/SLING-4665
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Timothee Maret
>             Fix For: Discovery Commons 1.0.0
>
>
> As discussed in SLING-4627, the Sling discovery would benefit from having a helper class that allow applications to compare two different topology views.
> As suggested by [~egli] this could be developed in a new bundle
> {code}
> <groupId>org.apache.sling</groupId>
> <artifactId>org.apache.sling.discovery.commons</artifactId>
> {code}
> The issue has no component/version assigned as it may require creating a new one for discovery.common.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)