You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/24 00:17:50 UTC

[GitHub] merlimat commented on a change in pull request #1277: fix bug in seek if no messages in topic

merlimat commented on a change in pull request #1277: fix bug in seek if no messages in topic
URL: https://github.com/apache/incubator-pulsar/pull/1277#discussion_r170398876
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -1259,6 +1259,9 @@ public void seek(MessageId messageId) throws PulsarClientException {
 
         long requestId = client.newRequestId();
         MessageIdImpl msgId = (MessageIdImpl) messageId;
+        if (msgId.getEntryId() == -1) {
 
 Review comment:
   This might not be necessary correct. (ledgerId=5, entryId=-1) is a valid position to seek and it should not got to "earliest"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services