You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2023/01/19 22:56:23 UTC

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2902: FINERACT-1840: Fee income is not realised if the loan got fully repaid

josehernandezfintecheandomx opened a new pull request, #2902:
URL: https://github.com/apache/fineract/pull/2902

   ## Description
   
   A Loan with a NSF fee is added (specific due date fee) and the loan got fully repaid on the same day the Fee income is not realised, the Accrual transaction is not added
   
   [FINERACT-1840](https://issues.apache.org/jira/browse/FINERACT-1840)
   
   <img width="1347" alt="Screenshot 2023-01-19 at 16 45 04" src="https://user-images.githubusercontent.com/44206706/213580591-99a78a6b-a7a3-4c1d-8348-b11c225d0398.png">
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] IOhacker merged pull request #2902: FINERACT-1840: Fee income is not realised if the loan got fully repaid

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker merged PR #2902:
URL: https://github.com/apache/fineract/pull/2902


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org