[GitHub] [spark] amaliujia commented on a diff in pull request #38287: [SPARK-40796][BUILD][FOLLOW-UP] Fix unused "type: ignore" comment

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38287:
URL: https://github.com/apache/spark/pull/38287#discussion_r997523189


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -322,15 +322,11 @@ def _convert_measure(
     ) -> proto.Aggregate.AggregateFunction:
         exp, fun = m
         measure = proto.Aggregate.AggregateFunction()
-        measure.function.name = fun  # type: ignore[attr-defined]
+        measure.function.name = fun
         if type(exp) is str:
-            measure.function.arguments.append(  # type: ignore[attr-defined]
-                self.unresolved_attr(exp)
-            )
+            measure.function.arguments.append(self.unresolved_attr(exp))
         else:
-            measure.function.arguments.append(  # type: ignore[attr-defined]
-                cast(Expression, exp).to_plan(session)
-            )
+            measure.function.arguments.append(cast(Expression, exp).to_plan(session))

Review Comment:
   This is formatted by the python formatter. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org