You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/26 05:33:30 UTC

[GitHub] [airflow] thiagorsqr opened a new issue #7881: Url parser in connection uses path as schema for HTTPs connections

thiagorsqr opened a new issue #7881: Url parser in connection uses path as schema for HTTPs connections
URL: https://github.com/apache/airflow/issues/7881
 
 
   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   Please complete the next sections or the issue will be closed.
   This questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 1.10.6 
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**: Azure
   - **OS** (e.g. from /etc/os-release): Ubuntu 18.04.4 LTS
   - **Kernel** (e.g. `uname -a`): Linux airflow 5.0.0-1035-azure #37-Ubuntu SMP Wed Mar 18 11:21:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
   - **Install tools**: 
   - **Others**:
   **What happened**: 
   
   When configuring HTTPs connection strings Airflow stills connects using http.
   
   HTTPS is only configurable using scheme as path under HTTP operator and connections strings
   
   User line 194 in connections shouldn't quoted_schema receive the scheme configuration from uri_parts.scheme instead of the path. Currently is using the scheme as the path from uri_parts. If that's the case https connection strings would need to be configured like 
   http://localhost:8080/https for it to work.
   
   ```
   https://github.com/apache/airflow/blob/a6fd74e706e0da24da1dfcceba14600c929a36cf/airflow/models/connection.py#L194
   ```
   <!-- (please include exact error messages if you can) -->
   
   **What you expected to happen**: Be able to configure https connections strings 
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**: Try to configure a https connection string and see how Airflow connections parse it.
   <!---
   
   As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
   
   If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md sytle of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**:
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7881: Url parser in connection uses path as schema for HTTPs connections

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7881: Url parser in connection uses path as schema for HTTPs connections
URL: https://github.com/apache/airflow/issues/7881#issuecomment-604491369
 
 
   Hello,
   Once I started working on it, but I did not find time to complete this change. If you want, you can rely on my change.
   https://github.com/apache/airflow/pull/5239
   Best regards,

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7881: Url parser in connection uses path as schema for HTTPs connections

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7881: Url parser in connection uses path as schema for HTTPs connections
URL: https://github.com/apache/airflow/issues/7881#issuecomment-604238756
 
 
   Thanks for opening your first issue here! Be sure to follow the issue template!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services