You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/22 05:15:09 UTC
Review Request: Factored out serializer/deserializer from state abstraction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6076/
-----------------------------------------------------------
Review request for mesos and John Sirois.
Description
-------
See summary.
Diffs
-----
src/messages/state.proto 1e53d40
src/state/leveldb.hpp PRE-CREATION
src/state/leveldb.cpp e70ba36
src/state/serializer.hpp PRE-CREATION
src/state/state.hpp e1d9c01
src/state/zookeeper.hpp PRE-CREATION
src/state/zookeeper.cpp 691faba
src/tests/state_tests.cpp 4936f4e
Diff: https://reviews.apache.org/r/6076/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Factored out serializer/deserializer from state
abstraction.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 22, 2012, 4:17 p.m., John Sirois wrote:
> > src/messages/state.proto, line 21
> > <https://reviews.apache.org/r/6076/diff/1/?file=125918#file125918line21>
> >
> > It not entirely clear how name and uuid play into the key portion of key/value pair - light docs would be helpful or even just s|effectively a key/value pair|a versioned key/value pair|
Done.
> On July 22, 2012, 4:17 p.m., John Sirois wrote:
> > src/state/state.hpp, line 152
> > <https://reviews.apache.org/r/6076/diff/1/?file=125922#file125922line152>
> >
> > Had to re-read dependant names - Ben educates John
Fun!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6076/#review9345
-----------------------------------------------------------
On July 22, 2012, 3:15 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6076/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 3:15 a.m.)
>
>
> Review request for mesos and John Sirois.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/messages/state.proto 1e53d40
> src/state/leveldb.hpp PRE-CREATION
> src/state/leveldb.cpp e70ba36
> src/state/serializer.hpp PRE-CREATION
> src/state/state.hpp e1d9c01
> src/state/zookeeper.hpp PRE-CREATION
> src/state/zookeeper.cpp 691faba
> src/tests/state_tests.cpp 4936f4e
>
> Diff: https://reviews.apache.org/r/6076/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Factored out serializer/deserializer from state
abstraction.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6076/#review9345
-----------------------------------------------------------
Ship it!
src/messages/state.proto
<https://reviews.apache.org/r/6076/#comment20073>
It not entirely clear how name and uuid play into the key portion of key/value pair - light docs would be helpful or even just s|effectively a key/value pair|a versioned key/value pair|
src/state/state.hpp
<https://reviews.apache.org/r/6076/#comment20075>
Had to re-read dependant names - Ben educates John
- John Sirois
On July 22, 2012, 3:15 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6076/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 3:15 a.m.)
>
>
> Review request for mesos and John Sirois.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/messages/state.proto 1e53d40
> src/state/leveldb.hpp PRE-CREATION
> src/state/leveldb.cpp e70ba36
> src/state/serializer.hpp PRE-CREATION
> src/state/state.hpp e1d9c01
> src/state/zookeeper.hpp PRE-CREATION
> src/state/zookeeper.cpp 691faba
> src/tests/state_tests.cpp 4936f4e
>
> Diff: https://reviews.apache.org/r/6076/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>