You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2023/05/18 01:47:49 UTC
[PR] Add celix_bundleCache_destroyArchive (celix)
PengZheng opened a new pull request, #558:
URL: https://github.com/apache/celix/pull/558
This PR is a first step to implement #556:
- It implements `celix_bundleCache_destroyArchive` to update the location lookup map after deleting archive.
- A crash caused by uninitialized `cache->fw` is fixed.
- More test cases for bundle cache added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add celix_bundleCache_destroyArchive (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng merged PR #558:
URL: https://github.com/apache/celix/pull/558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add celix_bundleCache_destroyArchive (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #558:
URL: https://github.com/apache/celix/pull/558#issuecomment-1552300595
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/558?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#558](https://app.codecov.io/gh/apache/celix/pull/558?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (821ab60) into [master](https://app.codecov.io/gh/apache/celix/commit/eaa79e00dd3fb999bcd4c221657eb88e2fe837cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eaa79e0) will **increase** coverage by `0.09%`.
> The diff coverage is `98.01%`.
```diff
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 77.65% 77.75% +0.09%
==========================================
Files 229 229
Lines 34928 34943 +15
==========================================
+ Hits 27125 27171 +46
+ Misses 7803 7772 -31
```
| [Impacted Files](https://app.codecov.io/gh/apache/celix/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libs/framework/src/celix\_bundle\_cache.c](https://app.codecov.io/gh/apache/celix/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2J1bmRsZV9jYWNoZS5j) | `98.02% <97.75%> (+9.07%)` | :arrow_up: |
| [libs/framework/src/bundle\_archive.c](https://app.codecov.io/gh/apache/celix/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9mcmFtZXdvcmsvc3JjL2J1bmRsZV9hcmNoaXZlLmM=) | `73.27% <100.00%> (+5.15%)` | :arrow_up: |
| [libs/framework/src/framework.c](https://app.codecov.io/gh/apache/celix/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `77.66% <100.00%> (-0.05%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/558/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org