You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/10 11:11:15 UTC

[GitHub] [pulsar] Jason918 commented on a change in pull request #11960: [PIP-63] Readonly-Topic-Ownership-Support

Jason918 commented on a change in pull request #11960:
URL: https://github.com/apache/pulsar/pull/11960#discussion_r706097157



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/Policies.java
##########
@@ -125,6 +125,12 @@
     @SuppressWarnings("checkstyle:MemberName")
     public String resource_group_name = null;
 
+    /**
+     * if writer_namespace is set, it means this is a readonly namespace. All data is read from writer_namespace
+     */
+    public String writerNamespace = null;

Review comment:
       @eolivelli Thank you for pointing this out, totally agree with you.
   Naming is always the difficult part.  'Readonly' is a little confusing in this project as there is already a 'ReadonlyManagedLedger', but it's completely different aspect of readonly.
   
   Added "shadowReaderModeEnabled" for this flag. Is that ok?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org