You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "echonesis (via GitHub)" <gi...@apache.org> on 2025/07/16 10:21:43 UTC
[PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
echonesis opened a new pull request, #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50
## What changes were proposed in this pull request?
Apache Ozone presently utilizes `goofys` as its S3 FUSE implementation. Given that the `goofys` repository has been forked and is now under the maintenance of StatCan, our intention is to transition to `mountpoint-s3`, an AWS Labs-maintained package, for subsequent development efforts.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13446
## How was this patch tested?
```
$ ./build.sh
...
$ docker run -it --rm apache/ozone-runner:dev bash
[hadoop@e9911f14f942 ~]$ which mount-s3
/usr/bin/mount-s3
[hadoop@e9911f14f942 ~]$ which goofys
/usr/bin/which: no goofys in
```
CI: https://github.com/echonesis/ozone-docker-runner/actions/runs/16316636413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50#discussion_r2215335832
##########
Dockerfile:
##########
@@ -57,7 +42,20 @@ RUN set -eux ; \
&& ln -sf /usr/bin/python3 /usr/bin/python
RUN sudo python3 -m pip install --upgrade pip
+# CSI / k8s / fuse / goofys dependency
COPY --from=go /go/bin/csc /usr/bin/csc
+# S3 FUSE support - mountpoint-s3
+ARG MOUNTPOINT_S3_VERSION=1.19.0
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ case "${ARCH}" in \
+ x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \
+ aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \
+ *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
+ esac; \
+ curl -L ${url} -o mount-s3.rpm ; \
Review Comment:
nit: please reduce duplication
```suggestion
x86_64) arch='x86_64' ;; \
aarch64) arch='arm64' ;; \
*) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
esac; \
curl -L "https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/${arch}/mount-s3-${MOUNTPOINT_S3_VERSION}-${arch}.rpm" -o mount-s3.rpm ; \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50#issuecomment-3088953627
Thanks @echonesis for the patch, @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
Posted by "echonesis (via GitHub)" <gi...@apache.org>.
echonesis commented on code in PR #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50#discussion_r2212137065
##########
Dockerfile:
##########
@@ -57,7 +42,19 @@ RUN set -eux ; \
&& ln -sf /usr/bin/python3 /usr/bin/python
RUN sudo python3 -m pip install --upgrade pip
+# CSI / k8s / fuse / goofys dependency
COPY --from=go /go/bin/csc /usr/bin/csc
+# S3 FUSE support
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ case "${ARCH}" in \
+ x86_64) arch='x86_64' ;; \
+ aarch64) arch='arm64' ;; \
+ *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
+ esac; \
+ curl -L -o /tmp/mount-s3.rpm "https://s3.amazonaws.com/mountpoint-s3-release/latest/${arch}/mount-s3.rpm"; \
+ dnf install -y /tmp/mount-s3.rpm; \
+ rm -f /tmp/mount-s3.rpm
Review Comment:
Thanks @jojochuang , it's a better solution.
I will modify it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
Posted by "echonesis (via GitHub)" <gi...@apache.org>.
echonesis commented on code in PR #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50#discussion_r2215600087
##########
Dockerfile:
##########
@@ -57,7 +42,20 @@ RUN set -eux ; \
&& ln -sf /usr/bin/python3 /usr/bin/python
RUN sudo python3 -m pip install --upgrade pip
+# CSI / k8s / fuse / goofys dependency
COPY --from=go /go/bin/csc /usr/bin/csc
+# S3 FUSE support - mountpoint-s3
+ARG MOUNTPOINT_S3_VERSION=1.19.0
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ case "${ARCH}" in \
+ x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \
+ aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \
+ *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
+ esac; \
+ curl -L ${url} -o mount-s3.rpm ; \
Review Comment:
Thanks @adoroszlai for reviewing the duplication issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50#discussion_r2212097574
##########
Dockerfile:
##########
@@ -57,7 +42,19 @@ RUN set -eux ; \
&& ln -sf /usr/bin/python3 /usr/bin/python
RUN sudo python3 -m pip install --upgrade pip
+# CSI / k8s / fuse / goofys dependency
COPY --from=go /go/bin/csc /usr/bin/csc
+# S3 FUSE support
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ case "${ARCH}" in \
+ x86_64) arch='x86_64' ;; \
+ aarch64) arch='arm64' ;; \
+ *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
+ esac; \
+ curl -L -o /tmp/mount-s3.rpm "https://s3.amazonaws.com/mountpoint-s3-release/latest/${arch}/mount-s3.rpm"; \
+ dnf install -y /tmp/mount-s3.rpm; \
+ rm -f /tmp/mount-s3.rpm
Review Comment:
Suggest to use a fixed version instead of the latest version:
```suggestion
RUN set -eux ; \
ARCH="$(arch)"; \
MOUNTPOINT_S3_VERSION="1.19.0"; \
case "${ARCH}" in \
x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \
aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \
*) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
esac; \
curl -L ${url} -o mount-s3.rpm ; \
dnf install -y mount-s3.rpm ; \
rm -f mount-s3.rpm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner [ozone-docker-runner]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #50:
URL: https://github.com/apache/ozone-docker-runner/pull/50#discussion_r2212097574
##########
Dockerfile:
##########
@@ -57,7 +42,19 @@ RUN set -eux ; \
&& ln -sf /usr/bin/python3 /usr/bin/python
RUN sudo python3 -m pip install --upgrade pip
+# CSI / k8s / fuse / goofys dependency
COPY --from=go /go/bin/csc /usr/bin/csc
+# S3 FUSE support
+RUN set -eux ; \
+ ARCH="$(arch)"; \
+ case "${ARCH}" in \
+ x86_64) arch='x86_64' ;; \
+ aarch64) arch='arm64' ;; \
+ *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
+ esac; \
+ curl -L -o /tmp/mount-s3.rpm "https://s3.amazonaws.com/mountpoint-s3-release/latest/${arch}/mount-s3.rpm"; \
+ dnf install -y /tmp/mount-s3.rpm; \
+ rm -f /tmp/mount-s3.rpm
Review Comment:
Suggest to use a fixed version:
```suggestion
RUN set -eux ; \
ARCH="$(arch)"; \
MOUNTPOINT_S3_VERSION="1.19.0"; \
case "${ARCH}" in \
x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \
aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \
*) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
esac; \
curl -L ${url} -o mount-s3.rpm ; \
dnf install -y mount-s3.rpm ; \
rm -f mount-s3.rpm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org