You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/02/24 16:31:22 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #754: Fix #960 Do
not expose mutable collections from FHIR BuildItems
ppalaga opened a new pull request #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] johnpoth commented on issue #754: Fix #960 Do not
expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
johnpoth commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590839782
@lburgazzoli yes that would be the idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] johnpoth commented on issue #754: Fix #960 Do not
expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
johnpoth commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590761348
@ppalaga looks great! However...
The idea here is to allow the user to add FHIR resources to the FHIR context before recording. Otherwise you'll get a ClassNotFoundException. See https://wiki.hl7.org/FHIR_Custom_Resources
Sorry for the late reply
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #754: Fix #960 Do
not expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #754: Fix #960 Do not
expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590810126
> allow the user to add FHIR resources to the FHIR context before recording.
Could you please explain how is my change preventing that? (Maybe I do not understand properly what you mean with add "FHIR resources")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #754: Fix #960 Do
not expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590833432
What about introducing a FHIRModelBuildItem ? (or whatever name make sense)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #754: Fix #960 Do not
expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590420019
@johnpoth could you please review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #754: Fix #960 Do not
expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590827024
> will make it harder for the user to add classes to the map
Yes, my patch is consciously preventing that for thread safety reasons.
I do not think we should let users write their own extensions to be able to ad their custom resources. Couldn't we enable this via `application.properties` or allow the users to provide their own `fhirversion.properties`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] johnpoth commented on issue #754: Fix #960 Do not
expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
johnpoth commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590823253
Hi @ppalaga, the map contains the resources (classes) to be loaded. Now that the map is immutable it will make it harder for the user to add classes to the map. HTH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #754: Fix #960 Do
not expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590767343
@johnpoth mind opening an issue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #754: Fix #960 Do not
expose mutable collections from FHIR BuildItems
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #754: Fix #960 Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/pull/754#issuecomment-590924697
> What about introducing a FHIRModelBuildItem ?
Do we really want to let users write extensions to provide their custom FHIR resources? I wonder why is that necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services