[GitHub] [hadoop] mehakmeet commented on a change in pull request #2141: HADOOP-17129. Validating storage keys in ABFS correctly

[GitBox <gi...@apache.org>]

mehakmeet commented on a change in pull request #2141:
URL: https://github.com/apache/hadoop/pull/2141#discussion_r455062213



##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/SimpleKeyProvider.java
##########
@@ -49,6 +51,27 @@ public String getStorageAccountKey(String accountName, Configuration rawConfig)
       LOG.warn("Unable to get key from credential providers. {}", ioe);
     }
 
+    // Validating the key.
+    try {
+      validateStorageAccountKey(key);
+    } catch (InvalidConfigurationValueException e) {
+      e.printStackTrace();

Review comment:
       Will it be fine to surround the ```throw new InvalidConfigurationValueException()``` with one more try-catch block? Since adding an exception to the method would break a test already present.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org