You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/22 05:54:01 UTC
[GitHub] [superset] villebro opened a new pull request, #21916: chore(plugin-chart-echarts): bump ECharts to 5.4.0
villebro opened a new pull request, #21916:
URL: https://github.com/apache/superset/pull/21916
### SUMMARY
Bump ECharts to latest version (5.4.0). Release notes since current 5.3.2 version:
- 5.3.3: https://dist.apache.org/repos/dist/dev/echarts/5.3.3-rc.1/RELEASE_NOTE.txt
- 5.4.0: https://dist.apache.org/repos/dist/dev/echarts/5.4.0-rc.1/RELEASE_NOTE.txt
Notable changes for Superset:
- Add support for confidence intervals with negative lower bounds. https://github.com/apache/echarts/issues/17086
- Fix for Pie charts when changing the percentage threshold or draw label lines control value in Explore: https://github.com/apache/echarts/issues/17412
This addresses the regression introduced by #20408 that had to be reverted by #20571 and adds storybooks for both confidence intervals and stacking with null values:
Confidence interval storybook:
Stacking with null values (the repro case from #20571):
In addition, a few previous storybooks were incorrectly using camelcase control values in the `formData` causing the `rawFormData` to render incorrectly, which lead to the x-axis formatter to not function properly. Now the x-axis displays with `smart_date` instead of showing epochs for all ECharts storybooks.
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21916: chore(plugin-chart-echarts): bump ECharts to 5.4.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21916:
URL: https://github.com/apache/superset/pull/21916#issuecomment-1287653534
# [Codecov](https://codecov.io/gh/apache/superset/pull/21916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21916](https://codecov.io/gh/apache/superset/pull/21916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4038af7) into [master](https://codecov.io/gh/apache/superset/commit/c2834cc14cf0db447b9759718411799eabcd8414?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2834cc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 4038af7 differs from pull request most recent head fd69a69. Consider uploading reports for the commit fd69a69 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21916 +/- ##
==========================================
- Coverage 66.91% 66.91% -0.01%
==========================================
Files 1807 1807
Lines 69139 69142 +3
Branches 7392 7395 +3
==========================================
+ Hits 46266 46268 +2
Misses 20963 20963
- Partials 1910 1911 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.32% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://codecov.io/gh/apache/superset/pull/21916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | `49.61% <0.00%> (-0.39%)` | :arrow_down: |
| [...c/components/Chart/DrillDetail/DrillDetailPane.tsx](https://codecov.io/gh/apache/superset/pull/21916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxEZXRhaWwvRHJpbGxEZXRhaWxQYW5lLnRzeA==) | `82.71% <0.00%> (+0.43%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #21916: chore(plugin-chart-echarts): bump ECharts to 5.4.0
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #21916:
URL: https://github.com/apache/superset/pull/21916#issuecomment-1288478400
Here's a dashboard on the eph env with the repro test case from the revert PR: http://34.219.50.78:8080/superset/dashboard/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #21916: chore(plugin-chart-echarts): bump ECharts to 5.4.0
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #21916:
URL: https://github.com/apache/superset/pull/21916#issuecomment-1287655556
/testenv up FEATURE_GENERIC_CHART_AXES=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #21916: chore(plugin-chart-echarts): bump ECharts to 5.4.0
Posted by GitBox <gi...@apache.org>.
villebro merged PR #21916:
URL: https://github.com/apache/superset/pull/21916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21916: chore(plugin-chart-echarts): bump ECharts to 5.4.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21916:
URL: https://github.com/apache/superset/pull/21916#issuecomment-1289160878
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21916: chore(plugin-chart-echarts): bump ECharts to 5.4.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21916:
URL: https://github.com/apache/superset/pull/21916#issuecomment-1287655821
@zhaoyongjie Ephemeral environment spinning up at http://34.219.50.78:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org