You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/23 05:11:16 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

michaeljmarshall opened a new pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424


   …thentication Methods (#12104)"
   
   This reverts commit 58680252b9c9d1be67474148130f0746d0feda6b.
   
   Master Issue: https://github.com/apache/pulsar/issues/12105
   
   ### Motivation
   
   Because the PIP is not completely implemented, we should not publish the interface changes in 2.10.
   
   ### Modifications
   
   * Revert the core PR for PIP 97.
   
   ### Verifying this change
   
   This change is trivial, because the original change was completely backwards compatible.
   
   ### Documentation
   
   - [x] `no-need-doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1048455364


   @codelipenghui - since we need to do a second RC for 2.10.0, I realized I should revert PIP 97 while I have the chance. I plan to complete the work soon, but it didn't make 2.10.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui edited a comment on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

Posted by GitBox <gi...@apache.org>.
codelipenghui edited a comment on pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1049466647


   @michaeljmarshall Ok, thanks for the update, any reason for reverting the change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1049466647


   Ok, thanks for the update, any reason for reverting the change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1051328986


   @codelipenghui - I reverted the commit that was responsible for updating the interfaces because none of the other work has been completed. It'd be a bit misleading for third parties to implement the interface since it is still synchronous. I plan to implement PIP 97 for Pulsar 2.11.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1048463601


   @codelipenghui - I had opened this PR with the intention of making sure tests pass. Apparently, we don't have tests configured to run on these PRs--I thought we did. I am going to merge this now since I believe it is the correct change and will therefore get included in the next 2.10 RC.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1048455485


   I am looking into why non of the tests ran.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall merged pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged pull request #14424:
URL: https://github.com/apache/pulsar/pull/14424


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org