You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Bhathiya <no...@github.com> on 2014/07/24 22:43:45 UTC
[jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Live tests were not added with BucketAccessControls, DefaultObjectAccessControls imlementations as CreateBucket Operation is required.
You can merge this Pull Request by running:
git pull https://github.com/hsbhathiya/jclouds-labs-google liveteststream_3
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/35
-- Commit Summary --
* JCLOUDS-458: Live tests for BucketAccessControls and DefaultObjectAccess Controls
-- File Changes --
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/BucketAccessControls.java (2)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/DefaultObjectAccessControlsTemplate.java (5)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApi.java (25)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApi.java (21)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/handlers/BucketAccessControlsBinder.java (4)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/handlers/DefaultObjectAccessControlsBinder.java (2)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiExpectTest.java (29)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiLiveTest.java (114)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApiExpectTest.java (27)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApiLiveTest.java (120)
M google-cloud-storage/src/test/resources/bucket_update_requestpayload.json (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/35.patch
https://github.com/jclouds/jclouds-labs-google/pull/35.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> @@ -31,7 +31,7 @@
> private BindToJsonPayload jsonBinder;
>
> @Override
> - public <R extends HttpRequest> R bindToRequest(R request, Map<String, Object> postParams) {
> + public <R extends HttpRequest> R bindToRequest(R request, Map<String, Object> postParams) throws IllegalArgumentException {
Unneeded change? `IllegalArgumentException` is a `RuntimeException` so we need not declare this.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16564080
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1262](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1262/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52980154
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> @@ -133,7 +126,7 @@ HttpResponse deleteDefaultObjectAccessControls(@PathParam("bucket") String bucke
> * @param generation
> * If present, selects a specific revision of this object
> *
> - * @return ListObjectAccessControls resource
> + * @return (@link ListObjectAccessControls}
bad Javadoc
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16572564
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1263](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1263/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52983934
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> @@ -96,15 +95,15 @@ BucketAccessControls getBucketAccessControls(@PathParam("bucket") String bucketN
> @Path("/b/{bucket}/acl")
> @OAuthScopes(STORAGE_FULLCONTROL_SCOPE)
> @MapBinder(BucketAccessControlsBinder.class)
> + @Nullable
Curious...when does this return `null`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17682801
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> +
> + @Test(groups = "live", dependsOnMethods = "testUpdateBucketacl")
> + public void testPatchBucketacl() {
> + BucketAccessControls bucketacl = BucketAccessControls.builder().bucket(BUCKET_NAME).entity("allUsers")
> + .role(Role.READER).build();
> + BucketAccessControls response = api().patchBucketAccessControls(BUCKET_NAME, "allUsers", bucketacl);
> +
> + assertNotNull(response);
> + assertEquals(response.getId(), BUCKET_NAME + "/allUsers");
> + assertEquals(response.getRole(), Role.READER);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testPatchBucketacl")
> + public void testDeleteBucketacl() {
> + api().deleteBucketAccessControls(BUCKET_NAME, "allUsers");
> + deleteBucket(BUCKET_NAME);
Inline this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17683125
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> @@ -155,7 +148,7 @@ HttpResponse deleteDefaultObjectAccessControls(@PathParam("bucket") String bucke
> * @param generation
> * If present, selects a specific revision of this object
> *
> - * @return DefaultObjectAccessControls resource
> + * @return D{@link DefaultObjectAccessControls }
Remove prefix "D".
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16563771
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #101](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/101/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50078045
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
Please address the minor nits, mostly Javadoc-related. This commit has a few unrelated changes: using UUID, Javadoc changes, and the actual new tests. Please break changes into component parts in future pull requests.
@mattstep This pull request has been open for almost a month! Do you plan to review it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52973592
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #121](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/121/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-53098009
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1264](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1264/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52986235
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1161](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1161/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50078538
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #122](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/122/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-53143970
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> +
> + assertNotNull(response);
> + assertEquals(response.getId(), BUCKET_NAME + "/allUsers");
> + assertEquals(response.getRole(), Role.READER);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testPatchBucketacl")
> + public void testDeleteBucketacl() {
> + api().deleteBucketAccessControls(BUCKET_NAME, "allUsers");
> + deleteBucket(BUCKET_NAME);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testDeleteBucketacl", expectedExceptions = ResourceNotFoundException.class)
> + public void testDeleteNotExistingBucketAccessControls() {
> + api().deleteBucketAccessControls(BUCKET_NAME, "allUsers");
> + }
Do we also need a test where the _bucket_ exists but the entity does not exist?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17683161
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> @@ -63,8 +63,7 @@ public static Properties defaultProperties() {
> properties.put(AUDIENCE, "https://accounts.google.com/o/oauth2/token");
> properties.put(SIGNATURE_OR_MAC_ALGORITHM, "RS256");
> properties.put(PROPERTY_SESSION_INTERVAL, 3600);
> - properties.setProperty(TEMPLATE, "osFamily=GCEL,osVersionMatches=1[012].[01][04],locationId=us-central1-a," +
> - "loginUser=jclouds");
> + properties.setProperty(TEMPLATE, "osFamily=DEBIAN,osVersionMatches=7\\..*,locationId=us-central1-a,loginUser=jclouds");
I'm confused by many of these changes -- why does a GCS commit have changes to GCE?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16618762
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> @@ -65,7 +64,7 @@
> * The entity holding the permission. Can be user-userId, user-emailAddress, group-groupId,
> * group-emailAddress, allUsers, or allAuthenticatedUsers.
> *
> - * @return a BucketAccessControls resource
> + * @return a {@link BucketAccessControls }resource
Repeated throughout.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16564433
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #100](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/100/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50077753
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
Base rebase?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-53114789
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #102](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/102/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50083327
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> @@ -133,7 +126,7 @@ HttpResponse deleteDefaultObjectAccessControls(@PathParam("bucket") String bucke
> * @param generation
> * If present, selects a specific revision of this object
> *
> - * @return ListObjectAccessControls resource
> + * @return (@ ListObjectAccessControls}
Incorrect syntax for Javadoc link.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16563842
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> +import org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.ObjectRole;
> +import org.jclouds.googlecloudstorage.domain.ListDefaultObjectAccessControls;
> +import org.jclouds.googlecloudstorage.domain.Resource.Kind;
> +import org.jclouds.googlecloudstorage.internal.BaseGoogleCloudStorageApiLiveTest;
> +import org.jclouds.rest.ResourceNotFoundException;
> +import org.testng.annotations.Test;
> +
> +public class DefaultObjectAccessControlsApiLiveTest extends BaseGoogleCloudStorageApiLiveTest {
> +
> + protected static final String BUCKET_NAME = "jcloudtestbucketdefaultoacl" + UUID.randomUUID();
> +
> + private DefaultObjectAccessControlsApi api() {
> + return api.getDefaultObjectAccessControlsApi();
> + }
> +
> + private void createBucket(String BucketName) {
Inline this method?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17683220
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
@hsbhathiya Can you rebase this commit? I see errors of the form:
```
[ERROR] /home/gaul/work/jclouds-labs-google/google-cloud-storage/src/main/java/o
rg/jclouds/googlecloudstorage/config/OAuthModuleWithoutTypeAdapters.java:[19,35]
cannot find symbol
symbol: class CredentialType
location: package org.jclouds.oauth.v2.config
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52992329
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1159](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1159/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50076927
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #119](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/119/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52989034
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testPatchDefaultObjectAcl")
> + public void testDeleteBucketAcl() {
> + api().deleteDefaultObjectAccessControls(BUCKET_NAME, "allUsers");
> + deleteBucket(BUCKET_NAME);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = { "testDeleteBucketAcl" }, expectedExceptions = { ResourceNotFoundException.class })
> + public void testDeleteNotExistingBucketAccessControls() {
> + api().deleteDefaultObjectAccessControls(BUCKET_NAME, "allUsers");
> + }
> +
> + private void deleteBucket(String bucketName) {
> + api.getBucketApi().deleteBucket(bucketName);
> + }
Have a method to clean up the bucket even if `testDeleteBucketAcl` fails?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17683343
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1158](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1158/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50076292
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #117](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/117/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52983058
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1162](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1162/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50082964
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> +
> + assertNotNull(response);
> + assertEquals(response.getId(), BUCKET_NAME + "/allUsers");
> + assertEquals(response.getRole(), Role.WRITER);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testUpdateBucketacl")
> + public void testListBucketacl() {
> + ListBucketAccessControls response = api().listBucketAccessControls(BUCKET_NAME);
> +
> + assertNotNull(response);
> + assertEquals(response.getKind(), Kind.BUCKET_ACCESS_CONTROLS);
> + assertNotNull(response.getItems());
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testUpdateBucketacl")
See comment for previous PR. If this test is not run single-threaded, this could cause `testGetBucketacl` to blow up.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17682948
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> + DefaultObjectAccessControls defaultObjectacl = DefaultObjectAccessControls.builder().bucket(BUCKET_NAME)
> + .entity("allUsers").role(ObjectRole.READER).build();
> + DefaultObjectAccessControls response = api().patchDefaultObjectAccessControls(BUCKET_NAME, "allUsers",
> + defaultObjectacl);
> +
> + assertNotNull(response);
> + assertEquals(response.getEntity(), "allUsers");
> + assertEquals(response.getRole(), ObjectRole.READER);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testPatchDefaultObjectacl")
> + public void testDeleteBucketacl() {
> + api().deleteDefaultObjectAccessControls(BUCKET_NAME, "allUsers");
> + deleteBucket(BUCKET_NAME);
> + }
> +
Trailing whitespace. Repeated a few times in this commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16572583
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #116](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/116/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52980210
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> +public class DefaultObjectAccessControlsApiLiveTest extends BaseGoogleCloudStorageApiLiveTest {
> +
> + protected static final String BUCKET_NAME = "jcloudtestbucketdefaultoacl" + UUID.randomUUID();
> +
> + private DefaultObjectAccessControlsApi api() {
> + return api.getDefaultObjectAccessControlsApi();
> + }
> +
> + private void createBucket(String BucketName) {
> + BucketTemplate template = new BucketTemplate().name(BucketName);
> + Bucket response = api.getBucketApi().createBucket(PROJECT_NUMBER, template);
> + assertNotNull(response);
> + }
> +
> + @Test(groups = "live")
> + public void testCreateDefaultObjectacl() {
Capitalize acl to `testCreateDefaultObjectAcl`? Repeated a few times below.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16572613
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> @@ -112,9 +111,7 @@ BucketAccessControls createBucketAccessControls(@PathParam("bucket") String buck
> @Consumes(MediaType.APPLICATION_JSON)
> @Path("/b/{bucket}/acl/{entity}")
> @OAuthScopes(STORAGE_FULLCONTROL_SCOPE)
> - @Fallback(NullOnNotFoundOr404.class)
> - @Nullable
> - HttpResponse deleteBucketAccessControls(@PathParam("bucket") String bucketName, @PathParam("entity") String entity);
> + void deleteBucketAccessControls(@PathParam("bucket") String bucketName, @PathParam("entity") String entity);
Should this not better return a boolean? Or what will happen if you try to delete a non-existent bucket?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17682843
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #118](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/118/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52984328
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Gaul <no...@github.com>.
> @@ -65,7 +64,7 @@
> * The entity holding the permission. Can be user-userId, user-emailAddress, group-groupId,
> * group-emailAddress, allUsers, or allAuthenticatedUsers.
> *
> - * @return a BucketAccessControls resource
> + * @return a {@link BucketAccessControls }resource
Trailing whitespace inside link.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r16564375
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1265](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1265/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-52988828
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> @@ -46,7 +46,7 @@
> private BucketAccessControls(@Nullable String id, @Nullable URI selfLink, @Nullable String etag, String bucket,
> String entity, @Nullable String entityId, Role role, @Nullable String email, @Nullable String domain,
> @Nullable ProjectTeam projectTeam) {
> - super(Kind.BUCKET_ACCESS_CONTROL, id == null ? (bucket + "/" + entity) : id, selfLink, etag);
Wow...ID really is nullable?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17682763
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> + @Test(groups = "live", dependsOnMethods = "testUpdateDefaultObjectAcl")
> + public void testPatchDefaultObjectAcl() {
> + DefaultObjectAccessControls defaultObjectAcl = DefaultObjectAccessControls.builder().bucket(BUCKET_NAME)
> + .entity("allUsers").role(ObjectRole.READER).build();
> + DefaultObjectAccessControls response = api().patchDefaultObjectAccessControls(BUCKET_NAME, "allUsers",
> + defaultObjectAcl);
> +
> + assertNotNull(response);
> + assertEquals(response.getEntity(), "allUsers");
> + assertEquals(response.getRole(), ObjectRole.READER);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testPatchDefaultObjectAcl")
> + public void testDeleteBucketAcl() {
> + api().deleteDefaultObjectAccessControls(BUCKET_NAME, "allUsers");
> + deleteBucket(BUCKET_NAME);
Inline?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17683319
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by Andrew Phillips <no...@github.com>.
> +
> + assertNotNull(response);
> + assertEquals(response.getEntity(), "allUsers");
> + assertEquals(response.getRole(), ObjectRole.OWNER);
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testUpdateDefaultObjectAcl")
> + public void testListDefaultObjectAcl() {
> + ListDefaultObjectAccessControls response = api().listDefaultObjectAccessControls(BUCKET_NAME);
> +
> + assertNotNull(response);
> + assertEquals(response.getKind(), Kind.OBJECT_ACCESS_CONTROLS);
> + assertNotNull(response.getItems());
> + }
> +
> + @Test(groups = "live", dependsOnMethods = "testUpdateDefaultObjectAcl")
Same comment as for the other patch live test
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17683299
Re: [jclouds-labs-google] JCLOUDS-458: Live tests for
BucketAccessControls, DefaultObjectAccessControls (#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #99](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/99/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35#issuecomment-50076275