[jira] [Commented] (SQOOP-1754) Sqoop2: Remove JarUtil class

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217226#comment-14217226 ] 

Sqoop QA bot commented on SQOOP-1754:
-------------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12682317/SQOOP-1754.patch against branch sqoop2.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} failed to apply patch (exit code 1):
{code}error: patch failed: connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java:39
error: connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java: patch does not apply
{code}

{color:green}SUCCESS:{color} Clean was successful

Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/636/console

This message is automatically generated.

> Sqoop2: Remove JarUtil class
> ----------------------------
>
>                 Key: SQOOP-1754
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1754
>             Project: Sqoop
>          Issue Type: Sub-task
>    Affects Versions: 1.99.4
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Qian Xu
>              Labels: newbie
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1754.patch
>
>
> We're currently using {{[JarUtil|https://github.com/apache/sqoop/blob/sqoop2/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java]}} class to help us find location of various jars. The implementation is very buggy as it depends on jar name and default Class Loader. We already do have facility in {{[ClassUtils|https://github.com/apache/sqoop/blob/sqoop2/common/src/main/java/org/apache/sqoop/utils/ClassUtils.java#L132]}} that is able to get location of jar given class name and we should take advantage of that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)